Skip to content

Commit bf470c5

Browse files
authored
Fix failing smoke tests (microsoft#15574)
1 parent 016411a commit bf470c5

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

news/3 Code Health/15573.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix failing smoke tests on CI.

src/test/smoke/datascience.smoke.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import * as vscode from 'vscode';
1010
import { JUPYTER_EXTENSION_ID } from '../../client/common/constants';
1111
import { openFile, setAutoSaveDelayInWorkspaceRoot, waitForCondition } from '../common';
1212
import { EXTENSION_ROOT_DIR_FOR_TESTS, IS_SMOKE_TEST } from '../constants';
13-
import { noop, sleep } from '../core';
13+
import { sleep } from '../core';
1414
import { closeActiveWindows, initialize, initializeTest } from '../initialize';
1515
import { verifyExtensionIsAvailable } from './common';
1616

@@ -75,8 +75,8 @@ suite('Smoke Test: Datascience', () => {
7575
if (await fs.pathExists(outputFile)) {
7676
await fs.unlink(outputFile);
7777
}
78-
// Ignore exceptions (as native editor closes the document as soon as its opened);
79-
await openFile(file).catch(noop);
78+
79+
await vscode.commands.executeCommand('jupyter.opennotebook', vscode.Uri.file(file));
8080

8181
// Wait for 15 seconds for notebook to launch.
8282
// Unfortunately there's no way to know for sure it has completely loaded.

0 commit comments

Comments
 (0)