Fix messages not showing up in insiders (microsoft#4632)

rchiodo · web-flow · commit 0d565510ba16 · 2019-03-04T11:21:49.000-08:00
Add some more logging for issue #4424 For #4424  - [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR) - [x] Title summarizes what is changing - [x] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!) - [x] Has sufficient logging. - [ ] Has telemetry for enhancements. - [ ] Unit tests & system/integration tests are added/updated - [ ] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate - [ ] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed) - [ ] The wiki is updated with any design decisions/details.
diff --git a/build/webpack/common.js b/build/webpack/common.js
@@ -22,7 +22,6 @@ exports.nodeModulesToExternalize = [
     'request',
     'request-progress',
     'source-map-support',
-    'file-matcher',
     'diff-match-patch',
     'sudo-prompt',
     'node-stream-zip',
diff --git a/build/webpack/common.ts b/build/webpack/common.ts
@@ -24,7 +24,6 @@ export const nodeModulesToExternalize = [
     'request',
     'request-progress',
     'source-map-support',
-    'file-matcher',
     'diff-match-patch',
     'sudo-prompt',
     'node-stream-zip',
diff --git a/news/3 Code Health/4424.md b/news/3 Code Health/4424.md
@@ -0,0 +1 @@
+Add more logging to diagnose issues getting the Python Interactive window to show up
diff --git a/src/client/datascience/history.ts b/src/client/datascience/history.ts
@@ -427,6 +427,8 @@ export class History implements IHistory {
     }
 
     private async submitCode(code: string, file: string, line: number, id?: string, editor?: TextEditor) : Promise<void> {
+        this.logger.logInformation(`Submitting code for ${this.id}`);
+
         // Transmit this submission to all other listeners (in a live share session)
         if (!id) {
             id = uuid();
@@ -448,6 +450,7 @@ export class History implements IHistory {
 
             // Make sure we're loaded first.
             try {
+                this.logger.logInformation('Waiting for jupyter server and web panel ...');
                 await this.loadPromise;
             } catch (exc) {
                 // We should dispose ourselves if the load fails. Othewise the user
@@ -661,11 +664,17 @@ export class History implements IHistory {
     }
 
     private async loadJupyterServer(restart?: boolean): Promise<void> {
+        this.logger.logInformation('Getting jupyter server options ...');
+
         // Extract our options
         const options = await this.historyProvider.getNotebookOptions();
 
+        this.logger.logInformation('Connecting to jupyter server ...');
+
         // Now try to create a notebook server
         this.jupyterServer = await this.jupyterExecution.connectToNotebookServer(options);
+
+        this.logger.logInformation('Connected to jupyter server.');
     }
 
     private generateSysInfoCell = async (reason: SysInfoReason): Promise<ICell | undefined> => {

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Add more logging to diagnose issues getting the Python Interactive window to show up`