Commit f7d74dc
committed
Address code review feedback from PR #9
- Add Optional type hint to cluster parameter in DifferenceInDifferences
- Use significance_stars property in DiDResults.__repr__ instead of inline logic
- Add clarifying comments for vcov computation using solve()
- Import LinAlgError directly for cleaner exception handling1 parent cdc944d commit f7d74dc
2 files changed
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
90 | 91 | | |
91 | 92 | | |
92 | 93 | | |
93 | | - | |
| 94 | + | |
94 | 95 | | |
95 | 96 | | |
96 | 97 | | |
| |||
248 | 249 | | |
249 | 250 | | |
250 | 251 | | |
| 252 | + | |
251 | 253 | | |
252 | 254 | | |
253 | 255 | | |
| |||
963 | 965 | | |
964 | 966 | | |
965 | 967 | | |
| 968 | + | |
966 | 969 | | |
967 | 970 | | |
968 | 971 | | |
| |||
1528 | 1531 | | |
1529 | 1532 | | |
1530 | 1533 | | |
1531 | | - | |
| 1534 | + | |
1532 | 1535 | | |
1533 | 1536 | | |
1534 | 1537 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | 59 | | |
61 | | - | |
| 60 | + | |
62 | 61 | | |
63 | 62 | | |
64 | 63 | | |
| |||
0 commit comments