Multiple problems per line

JakubValtar · JakubValtar · commit b7770ab9dbfd · 2016-05-07T00:38:58.000+02:00
diff --git a/java/src/processing/mode/java/JavaEditor.java b/java/src/processing/mode/java/JavaEditor.java
@@ -11,6 +11,7 @@
 import java.util.Map;
 import java.util.logging.Level;
 import java.util.logging.Logger;
+import java.util.stream.Collectors;
 
 import javax.swing.*;
 import javax.swing.border.*;
@@ -195,9 +196,7 @@ public void mouseReleased(MouseEvent evt) {
 
     for (SketchCode code : getSketch().getCode()) {
       Document document = code.getDocument();
-      if (document != null) {
-        addDocumentListener(document);
-      }
+      addDocumentListener(document);
     }
   }
 
@@ -2513,7 +2512,7 @@ public List<Problem> getProblems() {
    * line or not
    */
   public void updateEditorStatus() {
-    Problem problem = findError(textarea.getCaretLine());
+    Problem problem = findProblem(textarea.getCaretLine());
     if (problem != null) {
       int type = problem.isError() ?
           EditorStatus.CURSOR_LINE_ERROR : EditorStatus.CURSOR_LINE_WARNING;
@@ -2530,21 +2529,36 @@ public void updateEditorStatus() {
 
 
   /**
-   * @return the LineMarker for the first error or warning on 'line'
+   * @return the Problem for the first error or warning on 'line'
    */
-  public Problem findError(int line) {
+  public Problem findProblem(int line) {
     JavaTextArea textArea = getJavaTextArea();
     int currentTab = getSketch().getCurrentCodeIndex();
-    for (Problem p : problems) {
-      if (p.getTabIndex() != currentTab) continue;
-      int pStartLine = p.getLineNumber();
-      int pEndOffset = p.getStopOffset();
-      int pEndLine = textArea.getLineOfOffset(pEndOffset);
-      if (line >= pStartLine && line <= pEndLine) {
-        return p;
-      }
-    }
-    return null;
+    return problems.stream()
+        .filter(p -> p.getTabIndex() == currentTab)
+        .filter(p -> {
+          int pStartLine = p.getLineNumber();
+          int pEndOffset = p.getStopOffset();
+          int pEndLine = textArea.getLineOfOffset(pEndOffset);
+          return line >= pStartLine && line <= pEndLine;
+        })
+        .findFirst()
+        .orElse(null);
+  }
+
+
+  public List<Problem> findProblems(int line) {
+    JavaTextArea textArea = getJavaTextArea();
+    int currentTab = getSketch().getCurrentCodeIndex();
+    return problems.stream()
+        .filter(p -> p.getTabIndex() == currentTab)
+        .filter(p -> {
+          int pStartLine = p.getLineNumber();
+          int pEndOffset = p.getStopOffset();
+          int pEndLine = textArea.getLineOfOffset(pEndOffset);
+          return line >= pStartLine && line <= pEndLine;
+        })
+        .collect(Collectors.toList());
   }
 
 
diff --git a/java/src/processing/mode/java/pdex/JavaTextAreaPainter.java b/java/src/processing/mode/java/pdex/JavaTextAreaPainter.java
@@ -272,8 +272,8 @@ static private String trimRight(String str) {
    * @param x
    */
   protected void paintErrorLine(Graphics gfx, int line, int x) {
-    Problem problem = getJavaEditor().findError(line);
-    if (problem != null) {
+    List<Problem> problems = getJavaEditor().findProblems(line);
+    for (Problem problem : problems) {
       int startOffset = problem.getStartOffset();
       int stopOffset = problem.getStopOffset();
 
@@ -362,8 +362,8 @@ public void setMode(Mode mode) {
   public String getToolTipText(MouseEvent evt) {
     int line = evt.getY() / getFontMetrics().getHeight() + textArea.getFirstLine();
     if (line >= 0 || line < textArea.getLineCount()) {
-      Problem problem = getJavaEditor().findError(line);
-      if (problem != null) {
+      List<Problem> problems = getJavaEditor().findProblems(line);
+      for (Problem problem : problems) {
         int lineStart = textArea.getLineStartOffset(line);
         int lineEnd = textArea.getLineStopOffset(line);
 
