work on quoting of java.ext.dirs (processing#4623)

benfry · benfry · commit 0ef548fa29ef · 2016-08-19T14:07:04.000-04:00
diff --git a/build/windows/config-cmd.xml b/build/windows/config-cmd.xml
@@ -30,7 +30,7 @@
   <jre>
     <path>java</path>
     <!-- Deal with jokers who install JOGL, ANTLR, etc system-wide -->
-    <opt>-Djava.ext.dirs=%EXEDIR%/java/lib/ext</opt>
+    <opt>-Djava.ext.dirs="%EXEDIR%/java/lib/ext"</opt>
     <!-- Prevent a user-installed JNA from conflicting with our version.
          https://github.com/processing/processing/issues/2239 -->
     <opt>-Djna.nosys=true</opt>
diff --git a/build/windows/config.xml b/build/windows/config.xml
@@ -27,7 +27,7 @@
   <jre>
     <path>java</path>
     <!-- Deal with jokers who install JOGL, ANTLR, etc system-wide -->
-    <opt>-Djava.ext.dirs=%EXEDIR%/java/lib/ext</opt>
+    <opt>-Djava.ext.dirs="%EXEDIR%/java/lib/ext"</opt>
     <!-- https://github.com/processing/processing/issues/2239 -->
     <opt>-Djna.nosys=true</opt>
     <!-- Because nosys is set to true, the DLL in the current working 
diff --git a/java/src/processing/mode/java/JavaBuild.java b/java/src/processing/mode/java/JavaBuild.java
@@ -956,13 +956,13 @@ protected boolean exportApplication(File destFolder,
     if (embedJava) {
       // if people don't embed Java, it might be a mess, but what can we do?
       if (exportPlatform == PConstants.MACOSX) {
-        runOptions.append("-Djava.ext.dirs=$APP_ROOT/Contents/PlugIns/jdk" +
+        runOptions.append("-Djava.ext.dirs=\"$APP_ROOT/Contents/PlugIns/jdk" +
                           PApplet.javaVersionName +
-                          ".jdk/Contents/Home/jre/lib/ext");
+                          ".jdk/Contents/Home/jre/lib/ext\"");
       } else if (exportPlatform == PConstants.WINDOWS) {
-        runOptions.append("-Djava.ext.dirs=%EXEDIR%/java/lib/ext");
+        runOptions.append("-Djava.ext.dirs=\"%EXEDIR%/java/lib/ext\"");
       } else if (exportPlatform == PConstants.LINUX) {
-        runOptions.append("-Djava.ext.dirs=$APPDIR/java/lib/ext");
+        runOptions.append("-Djava.ext.dirs=\"$APPDIR/java/lib/ext\"");
       }
     }
 
diff --git a/java/src/processing/mode/java/runner/Runner.java b/java/src/processing/mode/java/runner/Runner.java
@@ -266,13 +266,25 @@ protected StringList getMachineParams() {
       }
     }
 
-//    params.add("-Djava.ext.dirs=nuffing");
-
     if (Preferences.getBoolean("run.options.memory")) {
       params.append("-Xms" + Preferences.get("run.options.memory.initial") + "m");
       params.append("-Xmx" + Preferences.get("run.options.memory.maximum") + "m");
     }
 
+    // Surprised this wasn't here before; added for 3.2.1
+    params.append("-Djna.nosys=true");
+
+    // Added for 3.2.1, was still using the default ext.dirs in the PDE
+    try {
+      String extPath =
+        new File(Platform.getJavaHome(), "lib/ext").getCanonicalPath();
+      // quoting this on OS X causes it to fail
+      //params.append("-Djava.ext.dirs=\"" + extPath + "\"");
+      params.append("-Djava.ext.dirs=" + extPath);
+    } catch (IOException e) {
+      e.printStackTrace();
+    }
+
     if (Platform.isMacOS()) {
       params.append("-Xdock:name=" + build.getSketchClassName());
 //      params.add("-Dcom.apple.mrj.application.apple.menu.about.name=" +
