downgrade node-fetch to version that jupyter labs wants (#5962)

IanMatthewHuff · web-flow · commit b243f0d7eb8e · 2019-06-10T16:21:38.000-07:00
* downgrade node-fetch to version that jupyter labs wants

* move warning to extension
diff --git a/gulpfile.js b/gulpfile.js
@@ -235,6 +235,7 @@ function getAllowedWarningsForWebPack(buildConfig) {
             ];
         case 'extension':
             return [
+                'WARNING in ./node_modules/encoding/lib/iconv-loader.js',
                 'WARNING in ./node_modules/ws/lib/BufferUtil.js',
                 'WARNING in ./node_modules/ws/lib/buffer-util.js',
                 'WARNING in ./node_modules/ws/lib/Validation.js',
diff --git a/news/2 Fixes/5956.md b/news/2 Fixes/5956.md
@@ -0,0 +1 @@
+Fix jupyter services node-fetch connection issue
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2207,7 +2207,7 @@
         "monaco-editor-textmate": "^2.1.1",
         "monaco-textmate": "^3.0.0",
         "named-js-regexp": "^1.3.3",
-        "node-fetch": "^2.6.0",
+        "node-fetch": "^1.0.0",
         "node-stream-zip": "^1.6.0",
         "onigasm": "^2.2.2",
         "pidusage": "^1.2.0",

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix jupyter services node-fetch connection issue`