Merge ArgumentsHelper unit tests into one file (#6584)

kimadeline · web-flow · commit 97c06aa93db1 · 2019-07-15T10:25:47.000-07:00
* Merge tests
* Add news file
diff --git a/news/3 Code Health/6583.md b/news/3 Code Health/6583.md
@@ -0,0 +1 @@
+Merge ArgumentsHelper unit tests into one file.
diff --git a/src/test/common/argumentsHelper.unit.test.ts b/src/test/common/argumentsHelper.unit.test.ts
diff --git a/src/test/testing/common/argsHelper.unit.test.ts b/src/test/testing/common/argsHelper.unit.test.ts
@@ -66,7 +66,7 @@ suite('Unit Tests - Arguments Helper', () => {
         expect(values).to.be.lengthOf(2);
         expect(values).to.be.deep.equal(['value2', 'value3']);
     });
-    test('Get multiple Positional options and ineline values', () => {
+    test('Get multiple Positional options and inline values', () => {
         const args = ['-abc=1234', '--value-option=value1', '--no-value-option', 'value2', 'value3'];
         const values = argsHelper.getPositionalArguments(args, ['--value-option', '-abc'], ['--no-value-option']);
         expect(values).to.be.array();
@@ -80,13 +80,28 @@ suite('Unit Tests - Arguments Helper', () => {
         expect(values).to.be.lengthOf(1);
         expect(values).to.be.deep.equal(['value3']);
     });
-    test('Get multiplle Positional options with trailing value option', () => {
+    test('Get multiple Positional options with trailing value option', () => {
         const args = ['-abc', '1234', '--value-option', 'value1', '--value-option', 'value2', 'value3', '4'];
         const values = argsHelper.getPositionalArguments(args, ['--value-option', '-abc'], ['--no-value-option']);
         expect(values).to.be.array();
         expect(values).to.be.lengthOf(2);
         expect(values).to.be.deep.equal(['value3', '4']);
     });
+    test('Get Positional options with unknown args', () => {
+        const args = ['-abc', '1234', '--value-option', 'value1', '--value-option', 'value2', 'value3', '4'];
+        const values = argsHelper.getPositionalArguments(args, ['-abc'], ['--no-value-option']);
+        expect(values).to.be.array();
+        expect(values).to.be.lengthOf(4);
+        expect(values).to.be.deep.equal(['value1', 'value2', 'value3', '4']);
+    });
+    test('Get Positional options with no options parameters', () => {
+        const args = ['-abc', '1234', '--value-option', 'value1', '--value-option', 'value2', 'value3', '4'];
+        const values = argsHelper.getPositionalArguments(args);
+        expect(values).to.be.array();
+        expect(values).to.be.lengthOf(5);
+        expect(values).to.be.deep.equal(['1234', 'value1', 'value2', 'value3', '4']);
+        expect(values).to.be.deep.equal(argsHelper.getPositionalArguments(args, [], []));
+    });
     test('Filter to remove those with values', () => {
         const args = ['-abc', '1234', '--value-option', 'value1', '--value-option', 'value2', 'value3', '4'];
         const values = argsHelper.filterArguments(args, ['--value-option']);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Merge ArgumentsHelper unit tests into one file.`