JAVA-21602 | fixing sync code block (#14318)

GaetanoPiazzolla · web-flow · commit f372563ca2d4 · 2023-06-28T20:18:08.000+05:30
diff --git a/core-java-modules/core-java-concurrency-advanced-4/src/main/java/com/baeldung/producerconsumer/Consumer.java b/core-java-modules/core-java-concurrency-advanced-4/src/main/java/com/baeldung/producerconsumer/Consumer.java
@@ -17,30 +17,29 @@ public void run() {
 
     public void consume() {
         while (dataQueue.runFlag) {
-            synchronized (dataQueue) {
-                while (dataQueue.isEmpty() && dataQueue.runFlag) {
-                    try {
-                        dataQueue.waitOnEmpty();
-                    } catch (InterruptedException e) {
-                        e.printStackTrace();
-                        break;
-                    }
-                }
-                if (!dataQueue.runFlag) {
+            while (dataQueue.isEmpty() && dataQueue.runFlag) {
+                try {
+                    dataQueue.waitOnEmpty();
+                } catch (InterruptedException e) {
+                    e.printStackTrace();
                     break;
                 }
-                Message message = dataQueue.remove();
-                dataQueue.notifyAllForFull();
-                useMessage(message);
             }
+            if (!dataQueue.runFlag) {
+                break;
+            }
+            Message message = dataQueue.remove();
+            dataQueue.notifyAllForFull();
+            useMessage(message);
+
         }
         log.info("Consumer Stopped");
     }
 
     private void useMessage(Message message) {
         if (message != null) {
             log.info(String.format("[%s] Consuming Message. Id: %d, Data: %f%n",
-                Thread.currentThread().getName(), message.getId(), message.getData()));
+                    Thread.currentThread().getName(), message.getId(), message.getData()));
 
             //Sleeping on random time to make it realistic
             ThreadUtil.sleep((long) (message.getData() * 100));
diff --git a/core-java-modules/core-java-concurrency-advanced-4/src/main/java/com/baeldung/producerconsumer/Producer.java b/core-java-modules/core-java-concurrency-advanced-4/src/main/java/com/baeldung/producerconsumer/Producer.java
@@ -19,30 +19,29 @@ public void run() {
 
     public void produce() {
         while (dataQueue.runFlag) {
-            synchronized (dataQueue) {
-                while (dataQueue.isFull() && dataQueue.runFlag) {
-                    try {
-                        dataQueue.waitOnFull();
-                    } catch (InterruptedException e) {
-                        e.printStackTrace();
-                        break;
-                    }
-                }
-                if (!dataQueue.runFlag) {
+            while (dataQueue.isFull() && dataQueue.runFlag) {
+                try {
+                    dataQueue.waitOnFull();
+                } catch (InterruptedException e) {
+                    e.printStackTrace();
                     break;
                 }
-                Message message = generateMessage();
-                dataQueue.add(message);
-                dataQueue.notifyAllForEmpty();
             }
+            if (!dataQueue.runFlag) {
+                break;
+            }
+            Message message = generateMessage();
+            dataQueue.add(message);
+            dataQueue.notifyAllForEmpty();
+
         }
         log.info("Producer Stopped");
     }
 
     private Message generateMessage() {
         Message message = new Message(incrementAndGetId(), Math.random());
         log.info(String.format("[%s] Generated Message. Id: %d, Data: %f%n",
-            Thread.currentThread().getName(), message.getId(), message.getData()));
+                Thread.currentThread().getName(), message.getId(), message.getData()));
 
         //Sleeping on random time to make it realistic
         ThreadUtil.sleep((long) (message.getData() * 100));
