Skip to content

Commit d2ede7f

Browse files
author
rajatgarg
committed
Address review comments
1 parent 6c48489 commit d2ede7f

6 files changed

Lines changed: 80 additions & 18 deletions

File tree

‎core-java-modules/core-java-io-5/.gitignore‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
test-link*
2+
0.*

‎core-java-modules/core-java-io-5/README.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
## Core Java IO
2+
3+
This module contains articles about core Java input and output (IO)
4+
5+
### Relevant Articles:
6+
7+
- [[<-- Prev]](/core-java-modules/core-java-io-4)
8+

‎core-java-modules/core-java-io-5/pom.xml‎

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<project xmlns="http://maven.apache.org/POM/4.0.0"
3+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
4+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
5+
<modelVersion>4.0.0</modelVersion>
6+
<artifactId>core-java-io-5</artifactId>
7+
<name>core-java-io-5</name>
8+
<packaging>jar</packaging>
9+
10+
<parent>
11+
<groupId>com.baeldung.core-java-modules</groupId>
12+
<artifactId>core-java-modules</artifactId>
13+
<version>0.0.1-SNAPSHOT</version>
14+
</parent>
15+
16+
<dependencies>
17+
<!-- Mime Type Resolution Libraries -->
18+
<dependency>
19+
<groupId>org.apache.tika</groupId>
20+
<artifactId>tika-core</artifactId>
21+
<version>${tika.version}</version>
22+
</dependency>
23+
<dependency>
24+
<groupId>net.sf.jmimemagic</groupId>
25+
<artifactId>jmimemagic</artifactId>
26+
<version>${jmime-magic.version}</version>
27+
</dependency>
28+
<dependency>
29+
<groupId>org.jodd</groupId>
30+
<artifactId>jodd-util</artifactId>
31+
<version>${jodd-util.version}</version>
32+
</dependency>
33+
<dependency>
34+
<groupId>com.j256.simplemagic</groupId>
35+
<artifactId>simplemagic</artifactId>
36+
<version>${simplemagic.version}</version>
37+
</dependency>
38+
</dependencies>
39+
40+
<build>
41+
<finalName>core-java-io-5</finalName>
42+
<resources>
43+
<resource>
44+
<directory>src/main/resources</directory>
45+
<filtering>true</filtering>
46+
</resource>
47+
</resources>
48+
<plugins>
49+
<plugin>
50+
<artifactId>maven-compiler-plugin</artifactId>
51+
<configuration>
52+
<source>11</source>
53+
<target>11</target>
54+
</configuration>
55+
</plugin>
56+
</plugins>
57+
</build>
58+
59+
<properties>
60+
<!-- Mime Type Libraries -->
61+
<tika.version>2.8.0</tika.version>
62+
<jmime-magic.version>0.1.5</jmime-magic.version>
63+
<jodd-util.version>6.2.1</jodd-util.version>
64+
<simplemagic.version>1.17</simplemagic.version>
65+
</properties>
66+
</project>

core-java-modules/core-java-io/src/test/java/com/baeldung/extension/ExtensionFromMimeTypeUnitTest.java renamed to core-java-modules/core-java-io-5/src/test/java/com/baeldung/extension/ExtensionFromMimeTypeUnitTest.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,8 @@
1111
import java.util.Set;
1212

1313
import org.apache.tika.mime.MimeTypeException;
14-
15-
import org.junit.Test;
16-
1714
import com.j256.simplemagic.ContentType;
15+
import org.junit.Test;
1816

1917
public class ExtensionFromMimeTypeUnitTest {
2018
private static final String IMAGE_JPEG_MIME_TYPE = "image/jpeg";
@@ -37,14 +35,14 @@ public void whenUsingJodd_thenGetFileExtension() {
3735
}
3836

3937
@Test
40-
public void whenUsingMimetypesFileTypeMap_thenGetFileExtension() {
38+
public void whenUsingSimpleMagic_thenGetFileExtension() {
4139
List<String> expectedExtensions = Arrays.asList("jpeg", "jpg", "jpe");
4240
String[] detectedExtensions = ContentType.fromMimeType(IMAGE_JPEG_MIME_TYPE).getFileExtensions();
4341
assertThat(detectedExtensions).containsExactlyElementsOf(expectedExtensions);
4442
}
4543

4644
@Test
47-
public void whenUsingCustomLogic_thenGetFileExtension() {
45+
public void whenUsingCustomMap_thenGetFileExtension() {
4846
Map<String, Set<String>> mimeExtensionsMap = new HashMap<>();
4947
List<String> expectedExtensions = Arrays.asList(".jpg", ".jpe", ".jpeg");
5048
addMimeExtensions(mimeExtensionsMap, "image/jpeg", ".jpg");

‎core-java-modules/core-java-io/pom.xml‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -43,17 +43,6 @@
4343
<version>${angus-activation.version}</version>
4444
<scope>test</scope>
4545
</dependency>
46-
<dependency>
47-
<groupId>org.jodd</groupId>
48-
<artifactId>jodd-util</artifactId>
49-
<version>${jodd-util.version}</version>
50-
</dependency>
51-
<dependency>
52-
<groupId>com.j256.simplemagic</groupId>
53-
<artifactId>simplemagic</artifactId>
54-
<version>${simplemagic.version}</version>
55-
</dependency>
56-
5746
</dependencies>
5847

5948
<build>
@@ -153,8 +142,6 @@
153142
<fscontext.version>4.4.2</fscontext.version>
154143
<jakarta-activation-api.version>2.1.2</jakarta-activation-api.version>
155144
<angus-activation.version>2.0.1</angus-activation.version>
156-
<jodd-util.version>6.2.1</jodd-util.version>
157-
<simplemagic.version>1.17</simplemagic.version>
158145
</properties>
159146

160147
</project>

‎core-java-modules/pom.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@
108108
<module>core-java-io-2</module>
109109
<module>core-java-io-3</module>
110110
<module>core-java-io-4</module>
111+
<module>core-java-io-5</module>
111112
<module>core-java-io-apis</module>
112113
<module>core-java-io-apis-2</module>
113114
<module>core-java-io-conversions</module>

0 commit comments

Comments
 (0)