[BAEL-7530] Fix Norm calculation by performing sqrt operation (#15846)

rajat-garg · rajatgarg · web-flow · commit 5e9182768060 · 2024-02-12T09:29:51.000-08:00
Co-authored-by: rajatgarg &lt;rajatgarg@adobe.com&gt;
diff --git a/core-java-modules/core-java-19/src/main/java/com/baeldung/vectors/VectorAPIExamples.java b/core-java-modules/core-java-19/src/main/java/com/baeldung/vectors/VectorAPIExamples.java
@@ -63,7 +63,7 @@ public int[] addTwoVectorsWithMasks(int[] arr1, int[] arr2) {
     public float[] scalarNormOfTwoArrays(float[] arr1, float[] arr2) {
         float[] finalResult = new float[arr1.length];
         for (int i = 0; i < arr1.length; i++) {
-            finalResult[i] = (arr1[i] * arr1[i] + arr2[i] * arr2[i]) * -1.0f;
+            finalResult[i] = (float) Math.sqrt(arr1[i] * arr1[i] + arr2[i] * arr2[i]);
         }
         return finalResult;
     }
@@ -77,13 +77,13 @@ public float[] vectorNormalForm(float[] arr1, float[] arr2) {
             var vb = FloatVector.fromArray(PREFERRED_SPECIES, arr2, i);
             var vc = va.mul(va)
               .add(vb.mul(vb))
-              .neg();
+              .sqrt();
             vc.intoArray(finalResult, i);
         }
 
         // tail cleanup
         for (; i < arr1.length; i++) {
-            finalResult[i] = (arr1[i] * arr1[i] + arr2[i] * arr2[i]) * -1.0f;
+            finalResult[i] = (float) Math.sqrt(arr1[i] * arr1[i] + arr2[i] * arr2[i]);
         }
         return finalResult;
     }
diff --git a/core-java-modules/core-java-19/src/test/java/com/baeldung/vectors/VectorAPIUnitTest.java b/core-java-modules/core-java-19/src/test/java/com/baeldung/vectors/VectorAPIUnitTest.java
@@ -28,15 +28,15 @@ public void whenTwoArraysProvided_thenVerifyVectorAdd() {
     public void whenTwoValuesProvided_thenComputeScalarNorm() {
         float[] arr1 = { 1, 2.3f };
         float[] arr2 = { 1.3f, 2.0f };
-        float[] result = { -2.6899998f, -9.29f };
+        float[] result = { 1.6401219f, 3.047950f };
         Assertions.assertArrayEquals(result, vector.scalarNormOfTwoArrays(arr1, arr2));
     }
 
     @Test
     public void whenTwoValuesProvided_thenComputeVectorNorm() {
         float[] arr1 = { 1, 2.3f };
         float[] arr2 = { 1.3f, 2.0f };
-        float[] result = { -2.6899998f, -9.29f };
+        float[] result = { 1.6401219f, 3.047950f };
         Assertions.assertArrayEquals(result, vector.vectorNormalForm(arr1, arr2));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public int[] addTwoVectorsWithMasks(int[] arr1, int[] arr2) {`
`63`	`63`	`public float[] scalarNormOfTwoArrays(float[] arr1, float[] arr2) {`
`64`	`64`	`float[] finalResult = new float[arr1.length];`
`65`	`65`	`for (int i = 0; i < arr1.length; i++) {`
`66`		`- finalResult[i] = (arr1[i] * arr1[i] + arr2[i] * arr2[i]) * -1.0f;`
	`66`	`+ finalResult[i] = (float) Math.sqrt(arr1[i] * arr1[i] + arr2[i] * arr2[i]);`
`67`	`67`	`}`
`68`	`68`	`return finalResult;`
`69`	`69`	`}`
`@@ -77,13 +77,13 @@ public float[] vectorNormalForm(float[] arr1, float[] arr2) {`
`77`	`77`	`var vb = FloatVector.fromArray(PREFERRED_SPECIES, arr2, i);`
`78`	`78`	`var vc = va.mul(va)`
`79`	`79`	`.add(vb.mul(vb))`
`80`		`- .neg();`
	`80`	`+ .sqrt();`
`81`	`81`	`vc.intoArray(finalResult, i);`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`// tail cleanup`
`85`	`85`	`for (; i < arr1.length; i++) {`
`86`		`- finalResult[i] = (arr1[i] * arr1[i] + arr2[i] * arr2[i]) * -1.0f;`
	`86`	`+ finalResult[i] = (float) Math.sqrt(arr1[i] * arr1[i] + arr2[i] * arr2[i]);`
`87`	`87`	`}`
`88`	`88`	`return finalResult;`
`89`	`89`	`}`