Skip to content

Commit 4cac5aa

Browse files
author
mikr
committed
JAVA-2824 Fix tests in Java 9 and above modules (Update after PR review)
1 parent 0e54f85 commit 4cac5aa

4 files changed

Lines changed: 35 additions & 32 deletions

File tree

‎core-java-modules/core-java-11/src/test/java/com/baeldung/java11/httpclient/test/HttpRequestUnitTest.java‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import java.time.Duration;
1919

2020
import org.junit.Test;
21+
import org.junit.jupiter.api.Disabled;
2122

2223
public class HttpRequestUnitTest {
2324

@@ -52,8 +53,8 @@ public void shouldUseHttp2WhenWebsiteUsesHttp2() throws IOException, Interrupted
5253
* This test will fail as soon as the given URL returns a HTTP 2 response.
5354
* Therefore, let's leave it commented out.
5455
* */
55-
56-
/* @Test
56+
@Test
57+
@Disabled
5758
public void shouldFallbackToHttp1_1WhenWebsiteDoesNotUseHttp2() throws IOException, InterruptedException, URISyntaxException, NoSuchAlgorithmException {
5859
HttpRequest request = HttpRequest.newBuilder()
5960
.uri(new URI("https://postman-echo.com/get"))
@@ -65,7 +66,7 @@ public void shouldFallbackToHttp1_1WhenWebsiteDoesNotUseHttp2() throws IOExcepti
6566
.send(request, HttpResponse.BodyHandlers.ofString());
6667

6768
assertThat(response.version(), equalTo(HttpClient.Version.HTTP_1_1));
68-
}*/
69+
}
6970

7071
@Test
7172
public void shouldReturnStatusOKWhenSendGetRequestWithDummyHeaders() throws IOException, InterruptedException, URISyntaxException {

‎core-java-modules/core-java-os/src/test/java/com/baeldung/screenshot/ScreenshotUnitTest.java‎

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import java.awt.image.BufferedImage;
1111
import java.io.File;
1212
import org.junit.Test;
13+
import org.junit.jupiter.api.Disabled;
1314

1415
import static org.junit.Assert.assertTrue;
1516

@@ -40,15 +41,16 @@ public void givenMultipleScreens_whenTakeScreenshot_thenSaveToFile() throws Exce
4041
assertTrue(imageFile.exists());
4142
}
4243

43-
// This methods needs a component as a parameter and can only be run from an application with a GUI
44-
// @Test
45-
// public void givenComponent_whenTakeScreenshot_thenSaveToFile(Component component) throws Exception {
46-
// Rectangle componentRect = component.getBounds();
47-
// BufferedImage bufferedImage = new BufferedImage(componentRect.width, componentRect.height, BufferedImage.TYPE_INT_ARGB);
48-
// component.paint(bufferedImage.getGraphics());
49-
// File imageFile = File.createTempFile("component-screenshot", "bmp");
50-
// ImageIO.write(bufferedImage, "bmp", imageFile);
51-
// assertTrue(imageFile.exists());
52-
// }
44+
// This methods needs a component as a parameter and can only be run from an application with a GUI
45+
@Test
46+
@Disabled
47+
public void givenComponent_whenTakeScreenshot_thenSaveToFile(Component component) throws Exception {
48+
Rectangle componentRect = component.getBounds();
49+
BufferedImage bufferedImage = new BufferedImage(componentRect.width, componentRect.height, BufferedImage.TYPE_INT_ARGB);
50+
component.paint(bufferedImage.getGraphics());
51+
File imageFile = File.createTempFile("component-screenshot", "bmp");
52+
ImageIO.write(bufferedImage, "bmp", imageFile);
53+
assertTrue(imageFile.exists());
54+
}
5355

5456
}

core-java-modules/core-java-time-measurements/src/test/java/com/baeldung/time/ElapsedTimeUnitTest.java renamed to core-java-modules/core-java-time-measurements/src/test/java/com/baeldung/time/ElapsedTimeManualTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import org.apache.commons.lang3.time.StopWatch;
1010
import org.junit.Test;
1111

12-
public class ElapsedTimeUnitTest {
12+
public class ElapsedTimeManualTest {
1313

1414
@Test
1515
public void givenRunningTask_whenMeasuringTimeWithCurrentTimeMillis_thenGetElapsedTime() throws InterruptedException {
@@ -55,7 +55,7 @@ public void givenRunningTask_whenMeasuringTimeWithStopWatch_thenGetElapsedTime()
5555
The below test depends on the elapsed time, which isn't ideal in a test.
5656
Also, it slows down test execution artificially.
5757
*/
58-
/*@Test
58+
@Test
5959
public void givenRunningTask_whenMeasuringTimeWithInstantClass_thenGetElapsedTime() throws InterruptedException {
6060
Instant start = Instant.now();
6161
System.out.println("start: " + start);
@@ -70,7 +70,7 @@ public void givenRunningTask_whenMeasuringTimeWithInstantClass_thenGetElapsedTim
7070

7171
System.out.println("elapsed: " + timeElapsed);
7272
assertEquals(true, (2000L <= timeElapsed) && (timeElapsed <= 3000L));
73-
}*/
73+
}
7474

7575
/**
7676
* Simulate task running for 2.5 seconds.

‎pom.xml‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1368,21 +1368,21 @@
13681368
<modules>
13691369
<module>core-java-modules/core-java-9</module>
13701370
<module>core-java-modules/core-java-9-improvements</module>
1371-
<module>core-java-modules/core-java-9-jigsaw</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1372-
<!-- <module>core-java-modules/core-java-9-new-features</module> --> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1371+
<module>core-java-modules/core-java-9-jigsaw</module>
1372+
<!-- <module>core-java-modules/core-java-9-new-features</module> --> <!-- uses preview features, to be decided how to handle -->
13731373
<module>core-java-modules/core-java-9-streams</module>
13741374
<module>core-java-modules/core-java-10</module>
1375-
<module>core-java-modules/core-java-11</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1375+
<module>core-java-modules/core-java-11</module>
13761376
<!-- <module>core-java-modules/core-java-12</module> --> <!-- uses preview features, to be decided how to handle -->
13771377
<!-- <module>core-java-modules/core-java-13</module> --> <!-- uses preview features, to be decided how to handle -->
13781378
<!-- <module>core-java-modules/core-java-14</module> --> <!-- uses preview features, to be decided how to handle -->
13791379
<module>core-java-modules/core-java-collections-set</module>
1380-
<module>core-java-modules/core-java-date-operations-1</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1381-
<module>core-java-modules/core-java-datetime-conversion</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1382-
<module>core-java-modules/core-java-datetime-string</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1380+
<module>core-java-modules/core-java-date-operations-1</module>
1381+
<module>core-java-modules/core-java-datetime-conversion</module>
1382+
<module>core-java-modules/core-java-datetime-string</module>
13831383
<module>core-java-modules/core-java-jpms</module>
1384-
<module>core-java-modules/core-java-os</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1385-
<module>core-java-modules/core-java-time-measurements</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1384+
<module>core-java-modules/core-java-os</module>
1385+
<module>core-java-modules/core-java-time-measurements</module>
13861386
<module>core-java-modules/multimodulemavenproject</module>
13871387
</modules>
13881388
</profile>
@@ -1412,21 +1412,21 @@
14121412
<modules>
14131413
<module>core-java-modules/core-java-9</module>
14141414
<module>core-java-modules/core-java-9-improvements</module>
1415-
<module>core-java-modules/core-java-9-jigsaw</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1416-
<!-- <module>core-java-modules/core-java-9-new-features</module> --> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1415+
<module>core-java-modules/core-java-9-jigsaw</module>
1416+
<!-- <module>core-java-modules/core-java-9-new-features</module> --> <!-- uses preview features, to be decided how to handle -->
14171417
<module>core-java-modules/core-java-9-streams</module>
14181418
<module>core-java-modules/core-java-10</module>
1419-
<module>core-java-modules/core-java-11</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1419+
<module>core-java-modules/core-java-11</module>
14201420
<!-- <module>core-java-modules/core-java-12</module> --> <!-- uses preview features, to be decided how to handle -->
14211421
<!-- <module>core-java-modules/core-java-13</module> --> <!-- uses preview features, to be decided how to handle -->
14221422
<!-- <module>core-java-modules/core-java-14</module> --> <!-- uses preview features, to be decided how to handle -->
14231423
<module>core-java-modules/core-java-collections-set</module>
1424-
<module>core-java-modules/core-java-date-operations-1</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1425-
<module>core-java-modules/core-java-datetime-conversion</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1426-
<module>core-java-modules/core-java-datetime-string</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1424+
<module>core-java-modules/core-java-date-operations-1</module>
1425+
<module>core-java-modules/core-java-datetime-conversion</module>
1426+
<module>core-java-modules/core-java-datetime-string</module>
14271427
<module>core-java-modules/core-java-jpms</module>
1428-
<module>core-java-modules/core-java-os</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1429-
<module>core-java-modules/core-java-time-measurements</module> <!-- to be fixed in http://team.baeldung.com/browse/JAVA-2824 -->
1428+
<module>core-java-modules/core-java-os</module>
1429+
<module>core-java-modules/core-java-time-measurements</module>
14301430
<module>core-java-modules/multimodulemavenproject</module>
14311431
</modules>
14321432
</profile>

0 commit comments

Comments
 (0)