Merge pull request #14373 from ukhan1980/BAEL-6697-fail-maven-build-if-coverage-falls

davidmartinezbarua · web-flow · commit 37510f10fd08 · 2023-07-24T19:16:29.000-03:00
[BAEL-6697] code for jacoco fail build
diff --git a/testing-modules/testing-libraries-2/pom.xml b/testing-modules/testing-libraries-2/pom.xml
@@ -1,6 +1,6 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0"
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
     <artifactId>testing-libraries-2</artifactId>
     <name>testing-libraries-2</name>
@@ -91,6 +91,32 @@
                             <goal>report</goal>
                         </goals>
                     </execution>
+                    <execution>
+                        <id>check-coverage</id>
+                        <phase>verify</phase>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                        <configuration>
+                            <rules>
+                                <rule>
+                                    <element>BUNDLE</element>
+                                    <limits>
+                                        <limit>
+                                            <counter>INSTRUCTION</counter>
+                                            <value>COVEREDRATIO</value>
+                                            <minimum>0.70</minimum>
+                                        </limit>
+                                        <limit>
+                                            <counter>BRANCH</counter>
+                                            <value>COVEREDRATIO</value>
+                                            <minimum>0.68</minimum>
+                                        </limit>
+                                    </limits>
+                                </rule>
+                            </rules>
+                        </configuration>
+                    </execution>
                 </executions>
             </plugin>
             <plugin>
diff --git a/testing-modules/testing-libraries-2/src/main/java/com/baeldung/jacocoexclusions/service/ProductService.java b/testing-modules/testing-libraries-2/src/main/java/com/baeldung/jacocoexclusions/service/ProductService.java
@@ -3,7 +3,13 @@
 public class ProductService {
     private static final double DISCOUNT = 0.25;
 
-    public double getSalePrice(double originalPrice) {
-        return originalPrice - originalPrice * DISCOUNT;
+public double getSalePrice(double originalPrice, boolean flag) {
+    double discount;
+    if (flag) {
+        discount = originalPrice - originalPrice * DISCOUNT;
+    } else {
+        discount = originalPrice;
     }
+    return discount;
 }
+}
diff --git a/testing-modules/testing-libraries-2/src/test/java/com/baeldung/jacocoexclusions/service/ProductServiceUnitTest.java b/testing-modules/testing-libraries-2/src/test/java/com/baeldung/jacocoexclusions/service/ProductServiceUnitTest.java
@@ -9,7 +9,14 @@ class ProductServiceUnitTest {
     @Test
     public void givenOriginalPrice_whenGetSalePrice_thenReturnsDiscountedPrice() {
         ProductService productService = new ProductService();
-        double salePrice = productService.getSalePrice(100);
+        double salePrice = productService.getSalePrice(100, true);
         assertEquals(salePrice, 75);
     }
+
+    @Test
+    public void givenOriginalPrice_whenGetSalePriceWithFlagFalse_thenReturnsDiscountedPrice() {
+        ProductService productService = new ProductService();
+        double salePrice = productService.getSalePrice(100, false);
+        assertEquals(salePrice, 100);
+    }
 }
