Skip to content

Commit 2b5199a

Browse files
author
rajatgarg
committed
Address review comments
1 parent 982a592 commit 2b5199a

1 file changed

Lines changed: 7 additions & 9 deletions

File tree

core-java-modules/core-java-io/src/test/java/com/baeldung/extension/ExtensionFromMimeTypeUnitTest.java

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.baeldung.extension;
22

33
import static org.assertj.core.api.Assertions.assertThat;
4-
import static org.junit.Assert.assertArrayEquals;
54
import static org.junit.Assert.assertEquals;
65

76
import java.util.Arrays;
@@ -32,29 +31,28 @@ public void whenUsingTika_thenGetFileExtension() throws MimeTypeException {
3231

3332
@Test
3433
public void whenUsingJodd_thenGetFileExtension() {
35-
String[] expectedExtensions = {"jpeg","jpg","jpe"};
34+
List<String> expectedExtensions = Arrays.asList("jpeg", "jpg", "jpe");
3635
String[] detectedExtensions = jodd.net.MimeTypes.findExtensionsByMimeTypes(IMAGE_JPEG_MIME_TYPE, false);
37-
assertThat(detectedExtensions).containsExactly(expectedExtensions);
36+
assertThat(detectedExtensions).containsExactlyElementsOf(expectedExtensions);
3837
}
3938

4039
@Test
4140
public void whenUsingMimetypesFileTypeMap_thenGetFileExtension() {
42-
String[] expectedExtensions = {"jpeg","jpg","jpe"};
41+
List<String> expectedExtensions = Arrays.asList("jpeg", "jpg", "jpe");
4342
ContentInfo contentInfo = new ContentInfo("", IMAGE_JPEG_MIME_TYPE, "", true);
4443
String[] detectedExtensions = contentInfo.getFileExtensions();
45-
assertThat(detectedExtensions).containsExactly(expectedExtensions);
44+
assertThat(detectedExtensions).containsExactlyElementsOf(expectedExtensions);
4645
}
4746

4847
@Test
4948
public void whenUsingCustomLogic_thenGetFileExtension() {
5049
Map<String, Set<String>> mimeExtensionsMap = new HashMap<>();
51-
Set<String> expectedExtensions = new HashSet<>(Arrays.asList(".jpeg",".jpg",".jpe"));
52-
addMimeExtensions(mimeExtensionsMap, "image/jpeg", ".jpeg");
50+
List<String> expectedExtensions = Arrays.asList(".jpg", ".jpe", ".jpeg");
5351
addMimeExtensions(mimeExtensionsMap, "image/jpeg", ".jpg");
5452
addMimeExtensions(mimeExtensionsMap, "image/jpeg", ".jpe");
53+
addMimeExtensions(mimeExtensionsMap, "image/jpeg", ".jpeg");
5554

56-
String mimeTypeToLookup = "image/jpeg";
57-
Set<String> detectedExtensions = mimeExtensionsMap.get(mimeTypeToLookup);
55+
Set<String> detectedExtensions = mimeExtensionsMap.get(IMAGE_JPEG_MIME_TYPE);
5856
assertThat(detectedExtensions).containsExactlyElementsOf(expectedExtensions);
5957
}
6058

0 commit comments

Comments
 (0)