Skip to content

Commit 2b22ffc

Browse files
author
CHANDRAKANT Kumar
committed
Fixed as par some more review comments.
1 parent ed75b80 commit 2b22ffc

6 files changed

Lines changed: 1 addition & 21 deletions

File tree

libraries-llms/README.md

Lines changed: 0 additions & 6 deletions
This file was deleted.

libraries-llms/src/test/java/com/baeldung/langchain/ChainWithDocumentLiveTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ public class ChainWithDocumentLiveTest {
3131

3232
@Test
3333
public void givenChainWithDocument_whenPrompted_thenValidResponse() {
34-
3534
EmbeddingModel embeddingModel = new AllMiniLmL6V2EmbeddingModel();
3635

3736
EmbeddingStore<TextSegment> embeddingStore = new InMemoryEmbeddingStore<>();
@@ -61,7 +60,6 @@ public void givenChainWithDocument_whenPrompted_thenValidResponse() {
6160

6261
logger.info(answer);
6362
assertNotNull(answer);
64-
6563
}
6664

6765
}

libraries-llms/src/test/java/com/baeldung/langchain/ChatWithDocumentLiveTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ public class ChatWithDocumentLiveTest {
3838

3939
@Test
4040
public void givenDocument_whenPrompted_thenValidResponse() {
41-
4241
Document document = loadDocument(Paths.get("src/test/resources/example-files/simpson's_adventures.txt"));
4342
DocumentSplitter splitter = DocumentSplitters.recursive(100, 0, new OpenAiTokenizer(GPT_3_5_TURBO));
4443
List<TextSegment> segments = splitter.split(document);
@@ -77,7 +76,6 @@ public void givenDocument_whenPrompted_thenValidResponse() {
7776

7877
logger.info(aiMessage.text());
7978
assertNotNull(aiMessage.text());
80-
8179
}
8280

8381
}

libraries-llms/src/test/java/com/baeldung/langchain/ChatWithMemoryLiveTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ public class ChatWithMemoryLiveTest {
2222

2323
@Test
2424
public void givenMemory_whenPrompted_thenValidResponse() {
25-
2625
ChatLanguageModel model = OpenAiChatModel.withApiKey(Constants.OPEN_AI_KEY);
2726
ChatMemory chatMemory = TokenWindowChatMemory.withMaxTokens(300, new OpenAiTokenizer(GPT_3_5_TURBO));
2827

@@ -38,9 +37,7 @@ public void givenMemory_whenPrompted_thenValidResponse() {
3837
.content();
3938
logger.info(answerWithName.text());
4039
chatMemory.add(answerWithName);
41-
assertThat(answerWithName.text()
42-
.contains("Kumar"));
43-
40+
assertThat(answerWithName.text()).contains("Kumar");
4441
}
4542

4643
}

libraries-llms/src/test/java/com/baeldung/langchain/PromptTemplatesLiveTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ public class PromptTemplatesLiveTest {
2121

2222
@Test
2323
public void givenPromptTemplate_whenSuppliedInput_thenValidResponse() {
24-
2524
PromptTemplate promptTemplate = PromptTemplate.from("Tell me a {{adjective}} joke about {{content}}..");
2625
Map<String, Object> variables = new HashMap<>();
2726
variables.put("adjective", "funny");
@@ -37,7 +36,6 @@ public void givenPromptTemplate_whenSuppliedInput_thenValidResponse() {
3736
String response = model.generate(prompt.text());
3837
logger.info(response);
3938
assertNotNull(response);
40-
4139
}
4240

4341
}

libraries-llms/src/test/java/com/baeldung/langchain/ServiceWithToolsLiveTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ public class ServiceWithToolsLiveTest {
1616
private static final Logger logger = LoggerFactory.getLogger(ServiceWithToolsLiveTest.class);
1717

1818
static class Calculator {
19-
2019
@Tool("Calculates the length of a string")
2120
int stringLength(String s) {
2221
return s.length();
@@ -26,17 +25,14 @@ int stringLength(String s) {
2625
int add(int a, int b) {
2726
return a + b;
2827
}
29-
3028
}
3129

3230
interface Assistant {
33-
3431
String chat(String userMessage);
3532
}
3633

3734
@Test
3835
public void givenServiceWithTools_whenPrompted_thenValidResponse() {
39-
4036
Assistant assistant = AiServices.builder(Assistant.class)
4137
.chatLanguageModel(OpenAiChatModel.withApiKey(Constants.OPEN_AI_KEY))
4238
.tools(new Calculator())
@@ -48,7 +44,6 @@ public void givenServiceWithTools_whenPrompted_thenValidResponse() {
4844

4945
logger.info(answer);
5046
assertThat(answer).contains("13");
51-
5247
}
5348

5449
}

0 commit comments

Comments
 (0)