From 808c653f4931c55f4c899dd57f61a17aaacb75f2 Mon Sep 17 00:00:00 2001 From: "deepsource-autofix[bot]" <62050782+deepsource-autofix[bot]@users.noreply.github.com> Date: Sun, 27 Nov 2022 01:59:03 +0000 Subject: [PATCH 1/2] Use field initialization shorthand --- src/board_builder.rs | 4 ++-- src/cache_table.rs | 8 ++++---- src/chess_move.rs | 6 +++--- src/gen_tables/magic.rs | 2 +- src/movegen/movegen.rs | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/board_builder.rs b/src/board_builder.rs index 437be70..e619427 100644 --- a/src/board_builder.rs +++ b/src/board_builder.rs @@ -113,9 +113,9 @@ impl BoardBuilder { ) -> BoardBuilder { let mut result = BoardBuilder { pieces: [None; 64], - side_to_move: side_to_move, + side_to_move, castle_rights: [white_castle_rights, black_castle_rights], - en_passant: en_passant, + en_passant, }; for piece in pieces.into_iter() { diff --git a/src/cache_table.rs b/src/cache_table.rs index 673b752..73c48cc 100644 --- a/src/cache_table.rs +++ b/src/cache_table.rs @@ -49,8 +49,8 @@ impl CacheTable { pub fn add(&mut self, hash: u64, entry: T) { let e = unsafe { self.table.get_unchecked_mut((hash as usize) & self.mask) }; *e = CacheTableEntry { - hash: hash, - entry: entry, + hash, + entry, }; } @@ -83,8 +83,8 @@ impl CacheTable { let e = unsafe { self.table.get_unchecked_mut((hash as usize) & self.mask) }; if replace(e.entry) { *e = CacheTableEntry { - hash: hash, - entry: entry, + hash, + entry, }; } } diff --git a/src/chess_move.rs b/src/chess_move.rs index 490bb10..843b311 100644 --- a/src/chess_move.rs +++ b/src/chess_move.rs @@ -24,9 +24,9 @@ impl ChessMove { #[inline] pub fn new(source: Square, dest: Square, promotion: Option) -> ChessMove { ChessMove { - source: source, - dest: dest, - promotion: promotion, + source, + dest, + promotion, } } diff --git a/src/gen_tables/magic.rs b/src/gen_tables/magic.rs index 791b8a3..e9978f7 100644 --- a/src/gen_tables/magic.rs +++ b/src/gen_tables/magic.rs @@ -75,7 +75,7 @@ fn generate_magic(sq: Square, piece: Piece, cur_offset: usize) -> usize { let mut new_magic = Magic { magic_number: EMPTY, - mask: mask, + mask, offset: new_offset as u32, rightshift: ((questions.len() as u64).leading_zeros() + 1) as u8, }; diff --git a/src/movegen/movegen.rs b/src/movegen/movegen.rs index d30d6e7..a05f093 100644 --- a/src/movegen/movegen.rs +++ b/src/movegen/movegen.rs @@ -22,7 +22,7 @@ impl SquareAndBitBoard { SquareAndBitBoard { square: sq, bitboard: bb, - promotion: promotion, + promotion, } } } From 46c50e0c7d1db5e85c6597142d7c046d3e8574bf Mon Sep 17 00:00:00 2001 From: "deepsource-autofix[bot]" <62050782+deepsource-autofix[bot]@users.noreply.github.com> Date: Sun, 27 Nov 2022 01:59:11 +0000 Subject: [PATCH 2/2] Format code with rustfmt --- src/cache_table.rs | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/cache_table.rs b/src/cache_table.rs index 73c48cc..9653144 100644 --- a/src/cache_table.rs +++ b/src/cache_table.rs @@ -48,10 +48,7 @@ impl CacheTable { #[inline] pub fn add(&mut self, hash: u64, entry: T) { let e = unsafe { self.table.get_unchecked_mut((hash as usize) & self.mask) }; - *e = CacheTableEntry { - hash, - entry, - }; + *e = CacheTableEntry { hash, entry }; } /// Replace an entry in the hash table with a user-specified replacement policy specified by @@ -82,10 +79,7 @@ impl CacheTable { pub fn replace_if bool>(&mut self, hash: u64, entry: T, replace: F) { let e = unsafe { self.table.get_unchecked_mut((hash as usize) & self.mask) }; if replace(e.entry) { - *e = CacheTableEntry { - hash, - entry, - }; + *e = CacheTableEntry { hash, entry }; } } }