Return environment variables in response body if requested... via an environment variable!

mendhak · mendhak · commit 28dc8b66e03c · 2022-10-30T15:53:56.000Z
Issue mendhak#43
diff --git a/index.js b/index.js
@@ -51,6 +51,9 @@ app.all('*', (req, res) => {
     echo.clientCertificate = req.socket.getPeerCertificate();
   }
   
+  if(process.env.ECHO_INCLUDE_ENV_VARS){
+    echo.env = process.env;
+  }
 
   if(req.is('application/json')){
     echo.json = JSON.parse(req.body)
diff --git a/tests.sh b/tests.sh
@@ -362,6 +362,38 @@ fi
 message " Stop containers "
 docker stop http-echo-tests
 
+message " Check that environment variables returned in response if enabled"
+docker run -d --rm -e ECHO_INCLUDE_ENV_VARS=1 --name http-echo-tests -p 8080:8080 -p 8443:8443 -t mendhak/http-https-echo
+sleep 5
+RESPONSE_BODY="$(curl -sk https://localhost:8443/ | jq -r  '.env.ECHO_INCLUDE_ENV_VARS')"
+
+if [ "$RESPONSE_BODY" == "1" ]
+then
+    passed "Environment variables present in the output"
+else
+    failed "Client certificate details found in output? ${RESPONSE_BODY}"
+    exit 1
+fi
+
+message " Stop containers "
+docker stop http-echo-tests
+
+message " Check that environment variables are not present in response by default"
+docker run -d --rm --name http-echo-tests -p 8080:8080 -p 8443:8443 -t mendhak/http-https-echo
+sleep 5
+RESPONSE_BODY_ENV_CHECK="$(curl -sk https://localhost:8443/ | jq 'has("env")')"
+
+if [ "$RESPONSE_BODY_ENV_CHECK" == "false" ]
+then
+    passed "Environment variables not present in the output by default"
+else
+    failed "Environment variables found in output?"
+    exit 1
+fi
+
+message " Stop containers "
+docker stop http-echo-tests
+
 popd
 rm -rf testarea
 message "DONE"

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,9 @@ app.all('*', (req, res) => {`
`51`	`51`	`echo.clientCertificate = req.socket.getPeerCertificate();`
`52`	`52`	`}`
`53`	`53`
	`54`	`+ if(process.env.ECHO_INCLUDE_ENV_VARS){`
	`55`	`+ echo.env = process.env;`
	`56`	`+ }`
`54`	`57`
`55`	`58`	`if(req.is('application/json')){`
`56`	`59`	`echo.json = JSON.parse(req.body)`