Define revision property when packaging jars in Dockerfile (feast-dev#410)

davidheryanto · feast-ci-bot · commit aa34a6bde20f · 2020-01-06T21:17:04.000+08:00
diff --git a/infra/docker/core/Dockerfile b/infra/docker/core/Dockerfile
@@ -12,7 +12,7 @@ WORKDIR /build
 # the existing .m2 directory to $FEAST_REPO_ROOT/.m2
 #
 ENV MAVEN_OPTS="-Dmaven.repo.local=/build/.m2/repository -DdependencyLocationsEnabled=false"
-RUN mvn --also-make --projects core,ingestion \
+RUN mvn --also-make --projects core,ingestion -Drevision=$REVISION \
   -DskipTests=true --batch-mode package
 #
 # Unpack the jar and copy the files into production Docker image
diff --git a/infra/docker/serving/Dockerfile b/infra/docker/serving/Dockerfile
@@ -12,7 +12,7 @@ WORKDIR /build
 # the existing .m2 directory to $FEAST_REPO_ROOT/.m2
 #
 ENV MAVEN_OPTS="-Dmaven.repo.local=/build/.m2/repository -DdependencyLocationsEnabled=false"
-RUN mvn --also-make --projects serving \
+RUN mvn --also-make --projects serving -Drevision=$REVISION \
   -DskipTests=true --batch-mode package
 
 # ============================================================

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ WORKDIR /build`
`12`	`12`	`# the existing .m2 directory to $FEAST_REPO_ROOT/.m2`
`13`	`13`	`#`
`14`	`14`	`ENV MAVEN_OPTS="-Dmaven.repo.local=/build/.m2/repository -DdependencyLocationsEnabled=false"`
`15`		`-RUN mvn --also-make --projects core,ingestion \`
	`15`	`+RUN mvn --also-make --projects core,ingestion -Drevision=$REVISION \`
`16`	`16`	`-DskipTests=true --batch-mode package`
`17`	`17`	`#`
`18`	`18`	`# Unpack the jar and copy the files into production Docker image`