lscpu: make lookup() use more consistent [coverity scan]

karelzak · karelzak · commit fe2e38f3b15f · 2019-05-28T11:58:51.000+02:00
We usually check lookup() return value. Let's do it in this case too.
It seems static analyzers will be happy with consistent code.

Signed-off-by: Karel Zak &lt;kzak@redhat.com&gt;
diff --git a/sys-utils/lscpu.c b/sys-utils/lscpu.c
@@ -626,8 +626,10 @@ read_basicinfo(struct lscpu_desc *desc, struct lscpu_modifier *mod)
 		read_physical_info_powerpc(desc);
 
 	if ((fp = ul_path_fopen(desc->procfs, "r", "sysinfo"))) {
-		while (fgets(buf, sizeof(buf), fp) != NULL && !desc->machinetype)
-			lookup(buf, "Type", &desc->machinetype);
+		while (fgets(buf, sizeof(buf), fp) != NULL) {
+			if (lookup(buf, "Type", &desc->machinetype))
+				break;
+		}
 		fclose(fp);
 	}
 
