Skip to content

GHTeam.getMembers() response does not include all users if user count >30 #145

Closed

Description

@if6was9

I have not gotten to the bottom of why this is happening, but getMembers() returns at most 30 members, even if the team has more.

I have a strong suspicion that the API is returning paged results but the response processing is not fetching the pages.

Will submit a PR if I can get it fixed.

Activity

  1. if6was9 commented on Dec 28, 2014

    @if6was9
    Author

    Confirmed to be a paging issue. Here is the relevant code:

    https://github.com/kohsuke/github-api/blob/master/src/main/java/org/kohsuke/github/GHTeam.java#L54-L56

    Since the declaration returns a Set, returning a PagedIterable isn't an option.

    I think an eager fetch to retrieve all pages and populate the Set makes the most sense.

    Note: I am positive that this API was not paged previously. Sometime in the last 6-12 months, GitHub has changed the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions