From 17d1994a532430f86429485f15c8bd108f96dfe7 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Mon, 9 Jan 2017 16:38:02 -0800 Subject: [PATCH 1/4] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 714567f3e6..746efda34c 100644 --- a/pom.xml +++ b/pom.xml @@ -7,7 +7,7 @@ github-api - 1.83 + 1.84-SNAPSHOT GitHub API for Java http://github-api.kohsuke.org/ GitHub API for Java @@ -16,7 +16,7 @@ scm:git:git@github.com/kohsuke/${project.artifactId}.git scm:git:ssh://git@github.com/kohsuke/${project.artifactId}.git http://${project.artifactId}.kohsuke.org/ - github-api-1.83 + HEAD From b9b6f4fd4412ab159d23abcdb4f1e5321e9624fa Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Mon, 9 Jan 2017 16:42:03 -0800 Subject: [PATCH 2/4] INFO level logging is harmful as it's reported to stdout by default --- src/main/java/org/kohsuke/github/GitHub.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/kohsuke/github/GitHub.java b/src/main/java/org/kohsuke/github/GitHub.java index df9353e032..42493db771 100644 --- a/src/main/java/org/kohsuke/github/GitHub.java +++ b/src/main/java/org/kohsuke/github/GitHub.java @@ -314,7 +314,7 @@ public GHRateLimit getRateLimit() throws IOException { || headerRateLimit.getResetDate().getTime() < observed.getResetDate().getTime() || headerRateLimit.remaining > observed.remaining) { headerRateLimit = observed; - LOGGER.log(Level.INFO, "Rate limit now: {0}", headerRateLimit); + LOGGER.log(FINE, "Rate limit now: {0}", headerRateLimit); } } } From 6cad4a3c336a091c74dcc8e9f39e4f8318eacabb Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Mon, 9 Jan 2017 16:43:03 -0800 Subject: [PATCH 3/4] static import for conciseness --- src/main/java/org/kohsuke/github/Requester.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/main/java/org/kohsuke/github/Requester.java b/src/main/java/org/kohsuke/github/Requester.java index 633e236dec..db70fbd64b 100644 --- a/src/main/java/org/kohsuke/github/Requester.java +++ b/src/main/java/org/kohsuke/github/Requester.java @@ -58,7 +58,7 @@ import org.apache.commons.lang.StringUtils; import static java.util.Arrays.asList; -import static java.util.logging.Level.FINE; +import static java.util.logging.Level.*; import static org.kohsuke.github.GitHub.MAPPER; /** @@ -352,16 +352,16 @@ private void noteRateLimit(String tailApiUrl) { try { observed.limit = Integer.parseInt(limit); } catch (NumberFormatException e) { - if (LOGGER.isLoggable(Level.FINEST)) { - LOGGER.log(Level.FINEST, "Malformed X-RateLimit-Limit header value " + limit, e); + if (LOGGER.isLoggable(FINEST)) { + LOGGER.log(FINEST, "Malformed X-RateLimit-Limit header value " + limit, e); } return; } try { observed.remaining = Integer.parseInt(remaining); } catch (NumberFormatException e) { - if (LOGGER.isLoggable(Level.FINEST)) { - LOGGER.log(Level.FINEST, "Malformed X-RateLimit-Remaining header value " + remaining, e); + if (LOGGER.isLoggable(FINEST)) { + LOGGER.log(FINEST, "Malformed X-RateLimit-Remaining header value " + remaining, e); } return; } @@ -369,8 +369,8 @@ private void noteRateLimit(String tailApiUrl) { observed.reset = new Date(Long.parseLong(reset)); // this is madness, storing the date as seconds root.updateRateLimit(observed); } catch (NumberFormatException e) { - if (LOGGER.isLoggable(Level.FINEST)) { - LOGGER.log(Level.FINEST, "Malformed X-RateLimit-Reset header value " + reset, e); + if (LOGGER.isLoggable(FINEST)) { + LOGGER.log(FINEST, "Malformed X-RateLimit-Reset header value " + reset, e); } } } From a3a715c3ba48cc85ce797c1cc414f0358d07b4d6 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Mon, 9 Jan 2017 16:50:08 -0800 Subject: [PATCH 4/4] [maven-release-plugin] prepare release github-api-1.84 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 746efda34c..55ba3aee49 100644 --- a/pom.xml +++ b/pom.xml @@ -7,7 +7,7 @@ github-api - 1.84-SNAPSHOT + 1.84 GitHub API for Java http://github-api.kohsuke.org/ GitHub API for Java @@ -16,7 +16,7 @@ scm:git:git@github.com/kohsuke/${project.artifactId}.git scm:git:ssh://git@github.com/kohsuke/${project.artifactId}.git http://${project.artifactId}.kohsuke.org/ - HEAD + github-api-1.84