From aa43e265b797ed327513b690c58ee6ede3e26767 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Sun, 15 Feb 2015 09:12:26 -0800 Subject: [PATCH 1/4] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 69ffb80db3..fca7b5670b 100644 --- a/pom.xml +++ b/pom.xml @@ -7,7 +7,7 @@ github-api - 1.62 + 1.63-SNAPSHOT GitHub API for Java http://github-api.kohsuke.org/ GitHub API for Java @@ -16,7 +16,7 @@ scm:git:git@github.com/kohsuke/${project.artifactId}.git scm:git:ssh://git@github.com/kohsuke/${project.artifactId}.git http://${project.artifactId}.kohsuke.org/ - github-api-1.62 + HEAD From 9aaf69cc9a4b54af6103a8e1e41188a26534f73d Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Mon, 2 Mar 2015 08:14:15 -0800 Subject: [PATCH 2/4] Added maling list --- pom.xml | 8 ++++++++ src/site/site.xml | 1 + 2 files changed, 9 insertions(+) diff --git a/pom.xml b/pom.xml index fca7b5670b..7a7c10fa1d 100644 --- a/pom.xml +++ b/pom.xml @@ -139,4 +139,12 @@ repo + + + + User List + github-api@googlegroups.com + https://groups.google.com/forum/#!forum/github-api + + diff --git a/src/site/site.xml b/src/site/site.xml index 252c697b6c..01eda5ec16 100644 --- a/src/site/site.xml +++ b/src/site/site.xml @@ -15,6 +15,7 @@ + From 11566891dc36cf8a13f3aec47480eeb66eb2a4a2 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Mon, 2 Mar 2015 08:31:54 -0800 Subject: [PATCH 3/4] Restored backward compatibility The signature of the method can change for the future, but it still has to return Label instances for older binaries --- src/main/java/org/kohsuke/github/GHIssue.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/kohsuke/github/GHIssue.java b/src/main/java/org/kohsuke/github/GHIssue.java index 0a33cdc013..69ffc29a86 100644 --- a/src/main/java/org/kohsuke/github/GHIssue.java +++ b/src/main/java/org/kohsuke/github/GHIssue.java @@ -52,7 +52,8 @@ public class GHIssue extends GHObject { protected String closed_at; protected int comments; protected String body; - protected List labels; + // for backward compatibility with < 1.63, this collection needs to hold instances of Label, not GHLabel + protected List