From 2144100f81300bf635c15cd737b7f78001132087 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Wed, 13 Nov 2013 13:05:29 -0800 Subject: [PATCH 1/5] [maven-release-plugin] prepare for next development iteration --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 46d97188c1..3531854c66 100644 --- a/pom.xml +++ b/pom.xml @@ -7,7 +7,7 @@ github-api - 1.46 + 1.47-SNAPSHOT GitHub API for Java http://github-api.kohsuke.org/ GitHub API for Java From 4188758d8488addeb7fb15c110842f3a9185f2e7 Mon Sep 17 00:00:00 2001 From: endeavor85 Date: Sun, 24 Nov 2013 02:54:18 -0600 Subject: [PATCH 2/5] Use `PagedIterator` to retrieve repository issues. Overcomes default 30 item page size limit. --- .../java/org/kohsuke/github/GHRepository.java | 19 ++++++++++++++++++- src/test/java/org/kohsuke/AppTest.java | 6 ++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/kohsuke/github/GHRepository.java b/src/main/java/org/kohsuke/github/GHRepository.java index dc897dfa68..f1a3100a46 100644 --- a/src/main/java/org/kohsuke/github/GHRepository.java +++ b/src/main/java/org/kohsuke/github/GHRepository.java @@ -143,7 +143,24 @@ public GHIssueBuilder createIssue(String title) { } public List getIssues(GHIssueState state) throws IOException { - return Arrays.asList(GHIssue.wrap(root.retrieve().to("/repos/" + owner.login + "/" + name + "/issues?state=" + state.toString().toLowerCase(), GHIssue[].class), this)); + return listIssues(state).asList(); + } + + /** + * Lists up all the issues in this repository. + */ + public PagedIterable listIssues(final GHIssueState state) { + return new PagedIterable() { + public PagedIterator iterator() { + return new PagedIterator(root.retrieve().asIterator(getApiTailUrl("issues?state="+state.toString().toLowerCase(Locale.ENGLISH)), GHIssue[].class)) { + @Override + protected void wrapUp(GHIssue[] page) { + for (GHIssue c : page) + c.wrap(GHRepository.this); + } + }; + } + }; } public GHReleaseBuilder createRelease(String tag) { diff --git a/src/test/java/org/kohsuke/AppTest.java b/src/test/java/org/kohsuke/AppTest.java index 2fbdf02cde..64908e7a87 100644 --- a/src/test/java/org/kohsuke/AppTest.java +++ b/src/test/java/org/kohsuke/AppTest.java @@ -79,6 +79,12 @@ public void testCreateIssue() throws IOException { o.close(); } + public void testGetIssues() throws Exception { + List closedIssues = gitHub.getUser("kohsuke").getRepository("github-api").getIssues(GHIssueState.CLOSED); + // prior to using PagedIterable GHRepository.getIssues(GHIssueState) would only retrieve 30 issues + assertTrue(closedIssues.size() > 30); + } + public void testRateLimit() throws IOException { System.out.println(gitHub.getRateLimit()); } From 0108a0c146cbe2146929238675fb3ff9057ec7e2 Mon Sep 17 00:00:00 2001 From: reid holmes Date: Tue, 26 Nov 2013 15:13:36 -0500 Subject: [PATCH 3/5] Add support for PULL_REQUEST_REVIEW_COMMENT event types. --- src/main/java/org/kohsuke/github/GHEvent.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/org/kohsuke/github/GHEvent.java b/src/main/java/org/kohsuke/github/GHEvent.java index 8c255988b3..efcb9e2f73 100644 --- a/src/main/java/org/kohsuke/github/GHEvent.java +++ b/src/main/java/org/kohsuke/github/GHEvent.java @@ -22,6 +22,7 @@ public enum GHEvent { MEMBER, PUBLIC, PULL_REQUEST, + PULL_REQUEST_REVIEW_COMMENT, PUSH, TEAM_ADD, WATCH From 2abf03ccb7cd24586a177952189384d604825f4e Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Wed, 27 Nov 2013 11:52:33 -0800 Subject: [PATCH 4/5] Minor doc improvement --- src/main/java/org/kohsuke/github/GHEvent.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/org/kohsuke/github/GHEvent.java b/src/main/java/org/kohsuke/github/GHEvent.java index efcb9e2f73..aeb0afe7e3 100644 --- a/src/main/java/org/kohsuke/github/GHEvent.java +++ b/src/main/java/org/kohsuke/github/GHEvent.java @@ -6,6 +6,7 @@ * See http://developer.github.com/v3/events/types/ * * @author Kohsuke Kawaguchi + * @see GHEventInfo */ public enum GHEvent { COMMIT_COMMENT, From 83a718c9dbd0dc0a6c27c66f54c7370d2f3ba962 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Wed, 27 Nov 2013 11:57:35 -0800 Subject: [PATCH 5/5] [maven-release-plugin] prepare release github-api-1.47 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 3531854c66..48d7ce7b8e 100644 --- a/pom.xml +++ b/pom.xml @@ -7,7 +7,7 @@ github-api - 1.47-SNAPSHOT + 1.47 GitHub API for Java http://github-api.kohsuke.org/ GitHub API for Java