From 40165628d61a0b91ff221c184140e5f280610fd8 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Tue, 7 May 2013 11:09:20 -0700 Subject: [PATCH 1/6] [maven-release-plugin] prepare for next development iteration --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index d89670607b..658b7aea14 100644 --- a/pom.xml +++ b/pom.xml @@ -7,7 +7,7 @@ github-api - 1.42 + 1.43-SNAPSHOT GitHub API for Java http://github-api.kohsuke.org/ GitHub API for Java From 589c5783a0c8aac8713767581f4e6dbe18d483d3 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Fri, 24 May 2013 12:01:56 -0700 Subject: [PATCH 2/6] "myself" only makes sense when there's a credential --- src/main/java/org/kohsuke/github/GitHub.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/kohsuke/github/GitHub.java b/src/main/java/org/kohsuke/github/GitHub.java index 8adf7e352f..7cebf53765 100644 --- a/src/main/java/org/kohsuke/github/GitHub.java +++ b/src/main/java/org/kohsuke/github/GitHub.java @@ -123,7 +123,7 @@ private GitHub(String apiUrl, String login, String oauthAccessToken, String pass } } - if (login==null) + if (login==null && encodedAuthorization!=null) login = getMyself().getLogin(); this.login = login; } From 6fc872b1fd692b2ce51fb73c6742a7b77a61cff9 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Sat, 6 Jul 2013 17:49:46 -0700 Subject: [PATCH 3/6] this is no longer efficient --- src/main/java/org/kohsuke/github/GHOrganization.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/kohsuke/github/GHOrganization.java b/src/main/java/org/kohsuke/github/GHOrganization.java index d8f8cfe036..e02eccd6ee 100644 --- a/src/main/java/org/kohsuke/github/GHOrganization.java +++ b/src/main/java/org/kohsuke/github/GHOrganization.java @@ -130,10 +130,13 @@ public GHTeam createTeam(String name, Permission p, GHRepository... repositories /** * List up repositories that has some open pull requests. + * + * This used to be an efficient method that didn't involve traversing every repository, but now + * it doesn't do any optimization. */ public List getRepositoriesWithOpenPullRequests() throws IOException { List r = new ArrayList(); - for (GHRepository repository : root.retrieve().to("/orgs/" + login + "/repos", GHRepository[].class)) { + for (GHRepository repository : listRepositories()) { repository.wrap(root); List pullRequests = repository.getPullRequests(GHIssueState.OPEN); if (pullRequests.size() > 0) { From c87d178a6af7ab68d214905479dfdf10a153c23b Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Sat, 6 Jul 2013 17:49:56 -0700 Subject: [PATCH 4/6] added a method that matches the convention elsewhere. --- .../java/org/kohsuke/github/GHPerson.java | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/main/java/org/kohsuke/github/GHPerson.java b/src/main/java/org/kohsuke/github/GHPerson.java index 7f65277f4f..721eeb2257 100644 --- a/src/main/java/org/kohsuke/github/GHPerson.java +++ b/src/main/java/org/kohsuke/github/GHPerson.java @@ -54,6 +54,25 @@ public synchronized Map getRepositories() throws IOExceptio return Collections.unmodifiableMap(repositories); } + /** + * Lists up all the repositories. + * + * Unlike {@link #getRepositories()}, this does not wait until all the repositories are returned. + */ + public PagedIterable listRepositories() { + return new PagedIterable() { + public PagedIterator iterator() { + return new PagedIterator(root.retrieve().asIterator("/users/" + login + "/repos", GHRepository[].class)) { + @Override + protected void wrapUp(GHRepository[] page) { + for (GHRepository c : page) + c.wrap(root); + } + }; + } + }; + } + /** * Loads repository list in a pagenated fashion. * @@ -63,6 +82,9 @@ public synchronized Map getRepositories() throws IOExceptio * * Every {@link Iterator#next()} call results in I/O. Exceptions that occur during the processing is wrapped * into {@link Error}. + * + * @deprecated + * Use {@link #listRepositories()} */ public synchronized Iterable> iterateRepositories(final int pageSize) { return new Iterable>() { From 5858a86624ddb3527a47b743024fbbda7219d371 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Sat, 6 Jul 2013 22:24:21 -0700 Subject: [PATCH 5/6] using the latest --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 658b7aea14..5cd25d4675 100644 --- a/pom.xml +++ b/pom.xml @@ -3,7 +3,7 @@ org.kohsuke pom - 4 + 6 github-api From 4956278f1716ec0dcd9595d3c7365e5802c7d026 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Sat, 6 Jul 2013 22:26:39 -0700 Subject: [PATCH 6/6] [maven-release-plugin] prepare release github-api-1.43 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 5cd25d4675..9ada1d503b 100644 --- a/pom.xml +++ b/pom.xml @@ -7,7 +7,7 @@ github-api - 1.43-SNAPSHOT + 1.43 GitHub API for Java http://github-api.kohsuke.org/ GitHub API for Java