MVC + jackson - List parameters not working fix jooby-project#1391

jknack · jknack · commit f8dd7f1583ba · 2019-10-01T17:00:54.000-03:00
diff --git a/examples/pom.xml b/examples/pom.xml
@@ -15,19 +15,19 @@
 
   <build>
     <plugins>
-<!--      <plugin>-->
-<!--        <artifactId>maven-compiler-plugin</artifactId>-->
-<!--        <version>3.8.1</version>-->
-<!--        <configuration>-->
-<!--          <annotationProcessorPaths>-->
-<!--            <path>-->
-<!--              <groupId>io.jooby</groupId>-->
-<!--              <artifactId>jooby-apt</artifactId>-->
-<!--              <version>${jooby.version}</version>-->
-<!--            </path>-->
-<!--          </annotationProcessorPaths>-->
-<!--        </configuration>-->
-<!--      </plugin>-->
+      <plugin>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>3.8.1</version>
+        <configuration>
+          <annotationProcessorPaths>
+            <path>
+              <groupId>io.jooby</groupId>
+              <artifactId>jooby-apt</artifactId>
+              <version>${jooby.version}</version>
+            </path>
+          </annotationProcessorPaths>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
   <dependencies>
diff --git a/examples/src/main/java/examples/MvcController.java b/examples/src/main/java/examples/MvcController.java
@@ -8,16 +8,14 @@
 import examples.jpa.Person;
 import io.jooby.annotations.POST;
 import io.jooby.annotations.Path;
-import io.jooby.annotations.PathParam;
-import io.jooby.annotations.QueryParam;
 
 import java.util.List;
 
 @Path("/jsonlist")
 public class MvcController {
 
-  @POST("/{id}")
-  public List<Person> post(@PathParam String id,  List<Person> people) {
+  @POST
+  public List<Person> post(List<Person> people) {
     return people;
   }
 }
diff --git a/examples/src/main/java/examples/WebSocketApp.java b/examples/src/main/java/examples/WebSocketApp.java
@@ -5,15 +5,9 @@
  */
 package examples;
 
-import io.jooby.ExecutionMode;
 import io.jooby.Jooby;
-import io.jooby.WebSocketCloseStatus;
 
 import java.nio.file.Paths;
-import java.util.concurrent.Executors;
-import java.util.concurrent.ScheduledExecutorService;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicInteger;
 
 public class WebSocketApp extends Jooby {
   {
@@ -27,21 +21,12 @@ public class WebSocketApp extends Jooby {
         ws.send("Got: " + msg.value());
       });
       initializer.onClose((ws, closeStatus) -> {
-        System.out.println("Closed " + closeStatus);
+        getLog().info("Closing with: {}", closeStatus);
       });
-
-      initializer.onError((ws, cause) -> {
-        if (ws.isOpen()) {
-          ws.send("error: " + cause.getMessage() );
-        } else {
-          ws.getContext().getRouter().getLog().error("error ", cause);
-        }
-      });
-
     });
   }
 
   public static void main(String[] args) {
-    runApp(args, ExecutionMode.DEFAULT, WebSocketApp::new);
+    runApp(args, WebSocketApp::new);
   }
 }
diff --git a/tests/src/test/java/io/jooby/Controller1391.java b/tests/src/test/java/io/jooby/Controller1391.java
@@ -0,0 +1,27 @@
+package io.jooby;
+
+import io.jooby.annotations.POST;
+import io.jooby.annotations.Path;
+
+import java.util.List;
+
+@Path("/1391")
+public class Controller1391 {
+
+  public static class Data1391 {
+    private String name;
+
+    public String getName() {
+      return name;
+    }
+
+    public void setName(String name) {
+      this.name = name;
+    }
+  }
+
+  @POST
+  public List<Data1391> post(List<Data1391> data) {
+    return data;
+  }
+}
diff --git a/tests/src/test/java/io/jooby/Issue1391.java b/tests/src/test/java/io/jooby/Issue1391.java
@@ -0,0 +1,24 @@
+package io.jooby;
+
+import io.jooby.json.JacksonModule;
+import okhttp3.MediaType;
+import okhttp3.RequestBody;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class Issue1391 {
+
+  @Test
+  public void issue1391() {
+    new JoobyRunner(app -> {
+      app.install(new JacksonModule());
+      app.mvc(new Controller1391());
+
+    }).ready(client -> {
+      client.post("/1391", RequestBody.create("[{\"name\" : \"1392\"}]", MediaType.get("application/json")), rsp -> {
+        assertEquals("[{\"name\":\"1392\"}]", rsp.body().string());
+      });
+    });
+  }
+}
