After handler must reflect errored status code on failure

jknack · jknack · commit c7d1bccf130f · 2021-07-25T12:09:45.000-03:00
fix jooby-project#2367
diff --git a/jooby/src/main/java/io/jooby/Route.java b/jooby/src/main/java/io/jooby/Route.java
@@ -269,6 +269,8 @@ public interface Handler extends Serializable, Aware {
           value = apply(ctx);
         } catch (Throwable x) {
           cause = x;
+          // Early mark context as errored response code:
+          ctx.setResponseCode(ctx.getRouter().errorCode(cause));
         }
         Object result;
         try {
diff --git a/tests/src/test/java/io/jooby/i2367/Issue2367.java b/tests/src/test/java/io/jooby/i2367/Issue2367.java
@@ -0,0 +1,45 @@
+package io.jooby.i2367;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import io.jooby.AccessLogHandler;
+import io.jooby.exception.BadRequestException;
+import io.jooby.junit.ServerTest;
+import io.jooby.junit.ServerTestRunner;
+
+public class Issue2367 {
+
+  @ServerTest
+  public void shouldAfterHandlerGetTheRightCode(ServerTestRunner runner) {
+    runner.define(app -> {
+      app.after((ctx, result, failure) -> {
+        ctx.send(
+            "statusCode: " + ctx.getResponseCode().value() + ", result: " + result + ", failure: "
+                + failure.getClass().getSimpleName());
+      });
+
+      app.get("/2367", ctx -> {
+        throw new BadRequestException("intentional error");
+      });
+
+    }).ready(http -> {
+      http.get("/2367", rsp -> {
+        assertEquals("statusCode: 400, result: null, failure: BadRequestException", rsp.body().string());
+      });
+    });
+  }
+
+  @ServerTest
+  public void shouldLog404(ServerTestRunner runner) {
+    runner.define(app -> {
+      app.decorator(new AccessLogHandler());
+
+      app.assets("/2367/*", "/2367");
+
+    }).ready(http -> {
+      http.get("/2367/index.js", rsp -> {
+        assertEquals(404, rsp.code());
+      });
+    });
+  }
+}

Original file line number	Diff line number	Diff line change
`@@ -269,6 +269,8 @@ public interface Handler extends Serializable, Aware {`
`269`	`269`	`value = apply(ctx);`
`270`	`270`	`} catch (Throwable x) {`
`271`	`271`	`cause = x;`
	`272`	`+ // Early mark context as errored response code:`
	`273`	`+ ctx.setResponseCode(ctx.getRouter().errorCode(cause));`
`272`	`274`	`}`
`273`	`275`	`Object result;`
`274`	`276`	`try {`