Skip to content

Commit 2f120b4

Browse files
feffijknack
authored andcommitted
fixed minor code issues (jooby-project#1174)
(cherry picked from commit 9ae00d1)
1 parent 97392da commit 2f120b4

File tree

5 files changed

+10
-12
lines changed

5 files changed

+10
-12
lines changed

modules/jooby-cassandra/src/main/java/org/jooby/cassandra/Cassandra.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -473,11 +473,11 @@ public class Cassandra implements Module {
473473

474474
private BiConsumer<Cluster, Config> cc;
475475

476-
private String db;
476+
private final String db;
477477

478478
@SuppressWarnings("rawtypes")
479479

480-
private List<Class> accesors = new ArrayList<>();
480+
private final List<Class> accesors = new ArrayList<>();
481481

482482
private Supplier<Cluster.Builder> builder = Cluster::builder;
483483

@@ -613,9 +613,7 @@ public void configure(final Env env, final Config conf, final Binder binder) {
613613
ServiceKey serviceKey = env.serviceKey();
614614

615615
Throwing.Function3<Class, String, Object, Void> bind = (type, name, value) -> {
616-
serviceKey.generate(type, name, k -> {
617-
binder.bind(k).toInstance(value);
618-
});
616+
serviceKey.generate(type, name, k -> binder.bind(k).toInstance(value));
619617
return null;
620618
};
621619

modules/jooby-cassandra/src/main/java/org/jooby/cassandra/CassandraMapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ class CassandraMapper implements Mapper<Object> {
216216
@SuppressWarnings({"unchecked", "rawtypes"})
217217
private static class DeferredHandler implements Deferred.Initializer0 {
218218

219-
private ListenableFuture future;
219+
private final ListenableFuture future;
220220

221221
public DeferredHandler(final ListenableFuture future) {
222222
this.future = future;

modules/jooby-cassandra/src/main/java/org/jooby/cassandra/CassandraSessionStore.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -318,9 +318,9 @@ public class CassandraSessionStore implements Store {
318318

319319
private final Throwing.Function<String, PreparedStatement> insertSQL;
320320

321-
private Throwing.Function<String, PreparedStatement> selectSQL;
321+
private final Throwing.Function<String, PreparedStatement> selectSQL;
322322

323-
private Throwing.Function<String, PreparedStatement> deleteSQL;
323+
private final Throwing.Function<String, PreparedStatement> deleteSQL;
324324

325325
public CassandraSessionStore(final com.datastax.driver.core.Session session, final int timeout) {
326326
this.session = requireNonNull(session, "Session required.");

modules/jooby-cassandra/src/main/java/org/jooby/cassandra/ConnectionString.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,11 +215,11 @@ class ConnectionString {
215215
public static final String SCHEMA = "cassandra://";
216216
private static final String SAMPLE = SCHEMA + "host[, host]*[:port]/keyspace";
217217

218-
private String[] address;
218+
private final String[] address;
219219

220-
private int port;
220+
private final int port;
221221

222-
private String keyspace;
222+
private final String keyspace;
223223

224224
private ConnectionString(final String[] address, final int port, final String keyspace) {
225225
this.address = address;

modules/jooby-cassandra/src/main/java/org/jooby/cassandra/Datastore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@
228228
*/
229229
@SuppressWarnings({"rawtypes", "unchecked" })
230230
public class Datastore {
231-
private MappingManager manager;
231+
private final MappingManager manager;
232232

233233
Datastore(final MappingManager manager) {
234234
this.manager = manager;

0 commit comments

Comments
 (0)