problem throwing StatusCodeException when there's an error handler fix jooby-project#1349

jknack · jknack · commit 2b3f11fa31ea · 2019-07-25T12:04:15.000-03:00
diff --git a/jooby/src/main/java/io/jooby/internal/RouterImpl.java b/jooby/src/main/java/io/jooby/internal/RouterImpl.java
@@ -385,6 +385,8 @@ private Route defineRoute(@Nonnull String method, @Nonnull String pattern,
   @Nonnull public Router start(@Nonnull Jooby owner) {
     if (err == null) {
       err = ErrorHandler.DEFAULT;
+    } else {
+      err = err.then(ErrorHandler.DEFAULT);
     }
     renderer.add(MessageEncoder.TO_STRING);
     ExecutionMode mode = owner.getExecutionMode();
diff --git a/tests/src/test/java/io/jooby/Issue1349.java b/tests/src/test/java/io/jooby/Issue1349.java
@@ -0,0 +1,46 @@
+package io.jooby;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class Issue1349 {
+
+  public static class App1349 extends Jooby {
+    {
+      error(IllegalAccessException.class, ((ctx, cause, statusCode) -> {
+        ctx.setResponseCode(statusCode);
+        ctx.send(cause.getMessage());
+      }));
+      get("/1349", ctx ->
+          something()
+      );
+      get("/1349/iae", ctx ->
+          throwsIAE()
+      );
+    }
+
+    private String throwsIAE() throws IllegalAccessException {
+      throw new IllegalAccessException("no-access");
+    }
+
+    public String something() {
+      throw new StatusCodeException(StatusCode.UNAUTHORIZED, "test");
+    }
+
+  }
+
+  @Test
+  public void issue1349() {
+    new JoobyRunner(App1349::new)
+        .ready(client -> {
+          client.get("/1349", rsp -> {
+            assertEquals(401, rsp.code());
+          });
+          client.get("/1349/iae", rsp -> {
+            assertEquals(500, rsp.code());
+            assertEquals("no-access", rsp.body().string());
+          });
+        });
+  }
+}

Original file line number	Diff line number	Diff line change
`@@ -385,6 +385,8 @@ private Route defineRoute(@Nonnull String method, @Nonnull String pattern,`
`385`	`385`	`@Nonnull public Router start(@Nonnull Jooby owner) {`
`386`	`386`	`if (err == null) {`
`387`	`387`	`err = ErrorHandler.DEFAULT;`
	`388`	`+ } else {`
	`389`	`+ err = err.then(ErrorHandler.DEFAULT);`
`388`	`390`	`}`
`389`	`391`	`renderer.add(MessageEncoder.TO_STRING);`
`390`	`392`	`ExecutionMode mode = owner.getExecutionMode();`