Jooby 1.6.x throws exception for empty cookies jooby-project#1331

jknack · jknack · commit 13a5fe843846 · 2019-07-15T19:32:29.000-03:00
diff --git a/jooby/src/main/java/org/jooby/internal/RequestImpl.java b/jooby/src/main/java/org/jooby/internal/RequestImpl.java
@@ -436,7 +436,7 @@ public Map<String, Mutant> headers() {
   public Mutant cookie(final String name) {
     List<String> values = req.cookies().stream().filter(c -> c.name().equalsIgnoreCase(name))
         .findFirst()
-        .map(cookie -> ImmutableList.of(cookie.value().get()))
+        .map(cookie -> ImmutableList.of(cookie.value().orElse("")))
         .orElse(ImmutableList.of());
 
     return new MutantImpl(require(ParserExecutor.class),
diff --git a/modules/coverage-report/src/test/java/org/jooby/issues/Issue1331.java b/modules/coverage-report/src/test/java/org/jooby/issues/Issue1331.java
@@ -0,0 +1,25 @@
+package org.jooby.issues;
+
+import org.jooby.test.ServerFeature;
+import org.junit.Test;
+
+public class Issue1331 extends ServerFeature {
+
+  {
+    get("/1331", req -> {
+      return req.cookie("login").value("not set");
+    });
+  }
+
+  @Test
+  public void shouldNotFailOnEmptyCookies() throws Exception {
+    request()
+        .get("/1331")
+        .header("Cookie", "login=;Version=1;Path=/1331")
+        .expect("");
+    request()
+        .get("/1331")
+        .expect("not set");
+  }
+
+}
