[Fix] Handle CameraFrame script changing enabled state (playcanvas#7282)

mvaligursky · Martin Valigursky · web-flow · commit 07c63a19b67a · 2025-01-15T15:11:55.000Z
* [Fix] Handle CameraFrame script changing enabled state

* lint

---------

Co-authored-by: Martin Valigursky &lt;mvaligursky@snapchat.com&gt;
diff --git a/scripts/utils/camera-frame.mjs b/scripts/utils/camera-frame.mjs
@@ -30,7 +30,7 @@ const RenderFormat = {
 
 /** @enum {string} */
 const DebugType = {
-    NONE: '',
+    NONE: 'none',
     SCENE: 'scene',
     SSAO: 'ssao',
     BLOOM: 'bloom',
@@ -367,6 +367,10 @@ class CameraFrame extends Script {
         this.on('destroy', () => {
             this.engineCameraFrame.destroy();
         });
+
+        this.on('state', (enabled) => {
+            this.engineCameraFrame.enabled = enabled;
+        });
     }
 
     postUpdate(dt) {
diff --git a/src/extras/render-passes/camera-frame.js b/src/extras/render-passes/camera-frame.js
@@ -2,6 +2,7 @@ import { Debug } from '../../core/debug.js';
 import { Color } from '../../core/math/color.js';
 import { math } from '../../core/math/math.js';
 import { PIXELFORMAT_111110F, PIXELFORMAT_RGBA16F, PIXELFORMAT_RGBA32F } from '../../platform/graphics/constants.js';
+import { GAMMA_SRGB } from '../../scene/constants.js';
 import { SSAOTYPE_NONE } from './constants.js';
 import { CameraFrameOptions, RenderPassCameraFrame } from './render-pass-camera-frame.js';
 
@@ -330,6 +331,9 @@ class CameraFrame {
             cameraComponent.rendering = null;
 
             cameraComponent.jitter = 0;
+
+            // no longer HDR rendering
+            cameraComponent.gammaCorrection = GAMMA_SRGB;
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ import { Debug } from '../../core/debug.js';`
`2`	`2`	`import { Color } from '../../core/math/color.js';`
`3`	`3`	`import { math } from '../../core/math/math.js';`
`4`	`4`	`import { PIXELFORMAT_111110F, PIXELFORMAT_RGBA16F, PIXELFORMAT_RGBA32F } from '../../platform/graphics/constants.js';`
	`5`	`+import { GAMMA_SRGB } from '../../scene/constants.js';`
`5`	`6`	`import { SSAOTYPE_NONE } from './constants.js';`
`6`	`7`	`import { CameraFrameOptions, RenderPassCameraFrame } from './render-pass-camera-frame.js';`
`7`	`8`
`@@ -330,6 +331,9 @@ class CameraFrame {`
`330`	`331`	`cameraComponent.rendering = null;`
`331`	`332`
`332`	`333`	`cameraComponent.jitter = 0;`
	`334`	`+`
	`335`	`+ // no longer HDR rendering`
	`336`	`+ cameraComponent.gammaCorrection = GAMMA_SRGB;`
`333`	`337`	`}`
`334`	`338`	`}`
`335`	`339`