fix python casting annotation issue

sslivkoff · sslivkoff · commit fa0f4b82108e · 2024-01-30T01:37:31.000-08:00
diff --git a/python/mesc/load.py b/python/mesc/load.py
@@ -9,7 +9,7 @@
 from . import validation
 
 if typing.TYPE_CHECKING:
-    from typing_extensions import cast, Literal, Any
+    from typing_extensions import Literal, Any
     from .types import RpcConfig
 
 
@@ -41,7 +41,7 @@ def read_config_data() -> RpcConfig:
 
     # validate
     validation.validate(config)
-    return cast(RpcConfig, config)
+    return config  # type: ignore
 
 
 @typing.overload
@@ -72,9 +72,7 @@ def read_env_config(*, validate: bool = True) -> RpcConfig | Any:
     # validate config
     if validate:
         validation.validate(config)
-        return cast(RpcConfig, config)
-    else:
-        return config
+    return config
 
 
 @typing.overload
@@ -124,6 +122,4 @@ def read_file_config(
     # validate config
     if validate:
         validation.validate(config)
-        return cast(RpcConfig, config)
-    else:
-        return config
+    return config
diff --git a/tests/adapters/python b/tests/adapters/python
@@ -4,27 +4,30 @@ from __future__ import annotations
 
 import argparse
 import json
-from typing import Sequence, cast, Union
+import typing
 
-from mesc.types import Endpoint, EndpointQuery
 import mesc
 
+if typing.TYPE_CHECKING:
+    from typing import Sequence, Union
+    from mesc.types import Endpoint, EndpointQuery
+
 
 def run_query(query: EndpointQuery) -> Union[Endpoint, Sequence[Endpoint], None]:
     if query["query_type"] == "default_endpoint":
-        default_fields = cast(mesc.types.DefaultEndpointQuery, query["fields"])
+        default_fields: mesc.types.DefaultEndpointQuery = query["fields"]
         return mesc.get_default_endpoint(**default_fields)
     elif query["query_type"] == "endpoint_by_name":
-        name_fields = cast(mesc.types.EndpointNameQuery, query["fields"])
+        name_fields: mesc.types.EndpointNameQuery = query["fields"]
         return mesc.get_endpoint_by_name(**name_fields)
     elif query["query_type"] == "endpoint_by_network":
-        network_fields = cast(mesc.types.EndpointNetworkQuery, query["fields"])
+        network_fields: mesc.types.EndpointNetworkQuery = query["fields"]
         return mesc.get_endpoint_by_network(**network_fields)
     elif query["query_type"] == "user_input":
-        user_input_fields = cast(mesc.types.UserInputQuery, query["fields"])
+        user_input_fields: mesc.types.UserInputQuery = query["fields"]
         return mesc.get_endpoint_by_query(**user_input_fields)
     elif query["query_type"] == "multi_endpoint":
-        multi_endpoint_fields = cast(mesc.types.MultiEndpointQuery, query["fields"])
+        multi_endpoint_fields: mesc.types.MultiEndpointQuery = query["fields"]
         return mesc.find_endpoints(**multi_endpoint_fields)
     elif query["query_type"] == "global_metadata":
         return mesc.get_global_metadata(**query["fields"])
