Revert "Log warning when menu uses bad commandId"

alexdima · alexdima · commit f632cf311d6e · 2016-07-08T16:48:40.000+03:00
This reverts commit 1828d8a.
diff --git a/src/vs/platform/commands/common/commandService.ts b/src/vs/platform/commands/common/commandService.ts
@@ -37,14 +37,4 @@ export class CommandService implements ICommandService {
 			}
 		});
 	}
-
-	isKnownCommand(commandId: string): boolean {
-		const command = CommandsRegistry.getCommand(commandId);
-
-		if (!command) {
-			return false;
-		}
-
-		return true;
-	}
 }
diff --git a/src/vs/platform/commands/common/commands.ts b/src/vs/platform/commands/common/commands.ts
@@ -14,7 +14,6 @@ export interface ICommandService {
 	_serviceBrand: any;
 	executeCommand<T>(commandId: string, ...args: any[]): TPromise<T>;
 	executeCommand(commandId: string, ...args: any[]): TPromise<any>;
-	isKnownCommand(commandId: string): boolean;
 }
 
 export interface ICommandsMap {
@@ -100,8 +99,5 @@ export const NullCommandService: ICommandService = {
 	_serviceBrand: undefined,
 	executeCommand() {
 		return TPromise.as(undefined);
-	},
-	isKnownCommand() {
-		return false;
 	}
 };
diff --git a/src/vs/workbench/electron-browser/integration.ts b/src/vs/workbench/electron-browser/integration.ts
@@ -172,9 +172,6 @@ export class ElectronIntegration {
 	private resolveKeybindings(actionIds: string[]): TPromise<{ id: string; binding: number; }[]> {
 		return this.partService.joinCreation().then(() => {
 			return arrays.coalesce(actionIds.map((id) => {
-				if (!this.commandService.isKnownCommand(id)) {
-					console.warn('Menu uses unknown command: ' + id);
-				}
 				let bindings = this.keybindingService.lookupKeybindings(id);
 
 				// return the first binding that can be represented by electron
diff --git a/src/vs/workbench/test/node/api/extHostApiCommands.test.ts b/src/vs/workbench/test/node/api/extHostApiCommands.test.ts
@@ -64,9 +64,6 @@ suite('ExtHostLanguageFeatureCommands', function() {
 			executeCommand(id, args): any {
 				let {handler} = CommandsRegistry.getCommands()[id];
 				return TPromise.as(instantiationService.invokeFunction(handler, args));
-			},
-			isKnownCommand(id) {
-				return true;
 			}
 		});
 		services.set(IMarkerService, new MarkerService());

Original file line number	Diff line number	Diff line change
`@@ -37,14 +37,4 @@ export class CommandService implements ICommandService {`
`37`	`37`	`}`
`38`	`38`	`});`
`39`	`39`	`}`
`40`		`-`
`41`		`- isKnownCommand(commandId: string): boolean {`
`42`		`- const command = CommandsRegistry.getCommand(commandId);`
`43`		`-`
`44`		`- if (!command) {`
`45`		`- return false;`
`46`		`- }`
`47`		`-`
`48`		`- return true;`
`49`		`- }`
`50`	`40`	`}`