Settings search - highlight word matches in description for results from bing

roblourens · roblourens · commit c00aeba6e8c1 · 2018-01-25T11:47:57.000-08:00
(still not using it to filter settings locally)
diff --git a/src/vs/workbench/parts/preferences/electron-browser/preferencesSearch.ts b/src/vs/workbench/parts/preferences/electron-browser/preferencesSearch.ts
@@ -258,7 +258,7 @@ class RemoteSearchProvider implements ISearchProvider {
 				scoredResults[getSettingKey(setting.key, 'core')] || // core setting
 				scoredResults[getSettingKey(setting.key)]; // core setting from original prod endpoint
 			if (remoteSetting && remoteSetting.score >= minScore) {
-				const settingMatches = new SettingMatches(this.options.filter, setting, false, false, (filter, setting) => preferencesModel.findValueMatches(filter, setting)).matches;
+				const settingMatches = new SettingMatches(this.options.filter, setting, false, true, (filter, setting) => preferencesModel.findValueMatches(filter, setting)).matches;
 				return { matches: settingMatches, score: remoteSetting.score };
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ class RemoteSearchProvider implements ISearchProvider {`
`258`	`258`	`scoredResults[getSettingKey(setting.key, 'core')] \|\| // core setting`
`259`	`259`	`scoredResults[getSettingKey(setting.key)]; // core setting from original prod endpoint`
`260`	`260`	`if (remoteSetting && remoteSetting.score >= minScore) {`
`261`		`- const settingMatches = new SettingMatches(this.options.filter, setting, false, false, (filter, setting) => preferencesModel.findValueMatches(filter, setting)).matches;`
	`261`	`+ const settingMatches = new SettingMatches(this.options.filter, setting, false, true, (filter, setting) => preferencesModel.findValueMatches(filter, setting)).matches;`
`262`	`262`	`return { matches: settingMatches, score: remoteSetting.score };`
`263`	`263`	`}`
`264`	`264`