server-ready feature: better error msg when chome not installed

weinand · weinand · commit bc0574de38d0 · 2019-03-21T15:23:48.000+01:00
diff --git a/extensions/debug-server-ready/src/extension.ts b/extensions/debug-server-ready/src/extension.ts
@@ -136,13 +136,20 @@ class ServerReadyDetector extends vscode.Disposable {
 				vscode.env.openExternal(vscode.Uri.parse(uri));
 				break;
 			case 'debugWithChrome':
-				vscode.debug.startDebugging(session.workspaceFolder, {
-					type: 'chrome',
-					name: 'Chrome Debug',
-					request: 'launch',
-					url: uri,
-					webRoot: args.webRoot || WEB_ROOT
-				}, session);
+
+				const chrome = vscode.extensions.getExtension('msjsdiag.debugger-for-chrome');
+				if (chrome) {
+					vscode.debug.startDebugging(session.workspaceFolder, {
+						type: 'chrome',
+						name: 'Chrome Debug',
+						request: 'launch',
+						url: uri,
+						webRoot: args.webRoot || WEB_ROOT
+					}, session);
+				} else {
+					const errMsg = localize('server.ready.chrome.not.installed', "The action 'debugWithChrome' requires the '{0}'", 'Debugger for Chrome');
+					vscode.window.showErrorMessage(errMsg, { modal: true }).then(_ => undefined);
+				}
 				break;
 			default:
 				// not supported
