Fix some compile errors resutling from readonly change

mjbvz · mjbvz · commit b4f6130fe4e7 · 2019-06-12T16:54:16.000-07:00
diff --git a/extensions/grunt/src/main.ts b/extensions/grunt/src/main.ts
@@ -230,7 +230,7 @@ class TaskDetector {
 		this.detectors.clear();
 	}
 
-	private updateWorkspaceFolders(added: vscode.WorkspaceFolder[], removed: vscode.WorkspaceFolder[]): void {
+	private updateWorkspaceFolders(added: readonly vscode.WorkspaceFolder[], removed: readonly vscode.WorkspaceFolder[]): void {
 		for (let remove of removed) {
 			let detector = this.detectors.get(remove.uri.toString());
 			if (detector) {
diff --git a/extensions/gulp/src/main.ts b/extensions/gulp/src/main.ts
@@ -209,7 +209,7 @@ class TaskDetector {
 		this.detectors.clear();
 	}
 
-	private updateWorkspaceFolders(added: vscode.WorkspaceFolder[], removed: vscode.WorkspaceFolder[]): void {
+	private updateWorkspaceFolders(added: readonly vscode.WorkspaceFolder[], removed: readonly vscode.WorkspaceFolder[]): void {
 		for (let remove of removed) {
 			let detector = this.detectors.get(remove.uri.toString());
 			if (detector) {
diff --git a/extensions/html-language-features/client/src/tagClosing.ts b/extensions/html-language-features/client/src/tagClosing.ts
@@ -32,7 +32,7 @@ export function activateTagClosing(tagProvider: (document: TextDocument, positio
 		isEnabled = true;
 	}
 
-	function onDidChangeTextDocument(document: TextDocument, changes: TextDocumentContentChangeEvent[]) {
+	function onDidChangeTextDocument(document: TextDocument, changes: readonly TextDocumentContentChangeEvent[]) {
 		if (!isEnabled) {
 			return;
 		}
diff --git a/extensions/jake/src/main.ts b/extensions/jake/src/main.ts
@@ -208,7 +208,7 @@ class TaskDetector {
 		this.detectors.clear();
 	}
 
-	private updateWorkspaceFolders(added: vscode.WorkspaceFolder[], removed: vscode.WorkspaceFolder[]): void {
+	private updateWorkspaceFolders(added: readonly vscode.WorkspaceFolder[], removed: readonly vscode.WorkspaceFolder[]): void {
 		for (let remove of removed) {
 			let detector = this.detectors.get(remove.uri.toString());
 			if (detector) {
diff --git a/extensions/typescript-language-features/src/features/bufferSyncSupport.ts b/extensions/typescript-language-features/src/features/bufferSyncSupport.ts
@@ -75,7 +75,7 @@ class BufferSynchronizer {
 		}
 	}
 
-	public change(filepath: string, events: vscode.TextDocumentContentChangeEvent[]) {
+	public change(filepath: string, events: readonly vscode.TextDocumentContentChangeEvent[]) {
 		if (!events.length) {
 			return;
 		}
@@ -210,7 +210,7 @@ class SyncedBuffer {
 		this.state = BufferState.Closed;
 	}
 
-	public onContentChanged(events: vscode.TextDocumentContentChangeEvent[]): void {
+	public onContentChanged(events: readonly vscode.TextDocumentContentChangeEvent[]): void {
 		if (this.state !== BufferState.Open) {
 			console.error(`Unexpected buffer state: ${this.state}`);
 		}
diff --git a/extensions/typescript-language-features/src/features/tagClosing.ts b/extensions/typescript-language-features/src/features/tagClosing.ts
@@ -46,7 +46,7 @@ class TagClosing extends Disposable {
 
 	private onDidChangeTextDocument(
 		document: vscode.TextDocument,
-		changes: vscode.TextDocumentContentChangeEvent[]
+		changes: readonly vscode.TextDocumentContentChangeEvent[]
 	) {
 		const activeDocument = vscode.window.activeTextEditor && vscode.window.activeTextEditor.document;
 		if (document !== activeDocument || changes.length === 0) {
diff --git a/src/vs/workbench/test/electron-browser/api/extHostDocumentSaveParticipant.test.ts b/src/vs/workbench/test/electron-browser/api/extHostDocumentSaveParticipant.test.ts
@@ -85,7 +85,7 @@ suite('ExtHostDocumentSaveParticipant', () => {
 			sub.dispose();
 
 			assert.ok(event);
-			assert.throws(() => { event.document = null!; });
+			assert.throws(() => { (event.document as any) = null!; });
 		});
 	});
 

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ class TaskDetector {`
`230`	`230`	`this.detectors.clear();`
`231`	`231`	`}`
`232`	`232`
`233`		`- private updateWorkspaceFolders(added: vscode.WorkspaceFolder[], removed: vscode.WorkspaceFolder[]): void {`
	`233`	`+ private updateWorkspaceFolders(added: readonly vscode.WorkspaceFolder[], removed: readonly vscode.WorkspaceFolder[]): void {`
`234`	`234`	`for (let remove of removed) {`
`235`	`235`	`let detector = this.detectors.get(remove.uri.toString());`
`236`	`236`	`if (detector) {`
Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,7 @@ class TaskDetector {`
`209`	`209`	`this.detectors.clear();`
`210`	`210`	`}`
`211`	`211`
`212`		`- private updateWorkspaceFolders(added: vscode.WorkspaceFolder[], removed: vscode.WorkspaceFolder[]): void {`
	`212`	`+ private updateWorkspaceFolders(added: readonly vscode.WorkspaceFolder[], removed: readonly vscode.WorkspaceFolder[]): void {`
`213`	`213`	`for (let remove of removed) {`
`214`	`214`	`let detector = this.detectors.get(remove.uri.toString());`
`215`	`215`	`if (detector) {`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ export function activateTagClosing(tagProvider: (document: TextDocument, positio`
`32`	`32`	`isEnabled = true;`
`33`	`33`	`}`
`34`	`34`
`35`		`- function onDidChangeTextDocument(document: TextDocument, changes: TextDocumentContentChangeEvent[]) {`
	`35`	`+ function onDidChangeTextDocument(document: TextDocument, changes: readonly TextDocumentContentChangeEvent[]) {`
`36`	`36`	`if (!isEnabled) {`
`37`	`37`	`return;`
`38`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ class TaskDetector {`
`208`	`208`	`this.detectors.clear();`
`209`	`209`	`}`
`210`	`210`
`211`		`- private updateWorkspaceFolders(added: vscode.WorkspaceFolder[], removed: vscode.WorkspaceFolder[]): void {`
	`211`	`+ private updateWorkspaceFolders(added: readonly vscode.WorkspaceFolder[], removed: readonly vscode.WorkspaceFolder[]): void {`
`212`	`212`	`for (let remove of removed) {`
`213`	`213`	`let detector = this.detectors.get(remove.uri.toString());`
`214`	`214`	`if (detector) {`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ class BufferSynchronizer {`
`75`	`75`	`}`
`76`	`76`	`}`
`77`	`77`
`78`		`- public change(filepath: string, events: vscode.TextDocumentContentChangeEvent[]) {`
	`78`	`+ public change(filepath: string, events: readonly vscode.TextDocumentContentChangeEvent[]) {`
`79`	`79`	`if (!events.length) {`
`80`	`80`	`return;`
`81`	`81`	`}`
`@@ -210,7 +210,7 @@ class SyncedBuffer {`
`210`	`210`	`this.state = BufferState.Closed;`
`211`	`211`	`}`
`212`	`212`
`213`		`- public onContentChanged(events: vscode.TextDocumentContentChangeEvent[]): void {`
	`213`	`+ public onContentChanged(events: readonly vscode.TextDocumentContentChangeEvent[]): void {`
`214`	`214`	`if (this.state !== BufferState.Open) {`
`215`	`215`	console.error(`Unexpected buffer state: ${this.state}`);
`216`	`216`	`}`