https-githubsup-com
diff --git a/‎build/azure-pipelines/product-compile.yml‎
Lines changed: 0 additions & 23 deletions b/‎build/azure-pipelines/product-compile.yml‎
Lines changed: 0 additions & 23 deletions
diff --git a/‎extensions/github-authentication/build/generateconfig.js‎
Lines changed: 0 additions & 35 deletions b/‎extensions/github-authentication/build/generateconfig.js‎
Lines changed: 0 additions & 35 deletions
diff --git a/‎extensions/github-authentication/src/common/clientRegistrar.ts‎
Lines changed: 0 additions & 102 deletions b/‎extensions/github-authentication/src/common/clientRegistrar.ts‎
Lines changed: 0 additions & 102 deletions
diff --git a/‎extensions/github-authentication/src/github.ts‎
Lines changed: 1 addition & 21 deletions b/‎extensions/github-authentication/src/github.ts‎
Lines changed: 1 addition & 21 deletions
@@ -72,29 +72,6 @@ steps:
     vstsFeed: 'npm-vscode'
   condition: and(succeeded(), ne(variables['CacheExists-Compilation'], 'true'), ne(variables['CacheRestored'], 'true'))
 
-- script: |
-    set -e
-    yarn generate-github-config
-  displayName: Generate GitHub config
-  env:
-    OSS_GITHUB_ID: "a5d3c261b032765a78de"
-    OSS_GITHUB_SECRET: $(oss-github-client-secret)
-    INSIDERS_GITHUB_ID: "31f02627809389d9f111"
-    INSIDERS_GITHUB_SECRET: $(insiders-github-client-secret)
-    STABLE_GITHUB_ID: "baa8a44b5e861d918709"
-    STABLE_GITHUB_SECRET: $(stable-github-client-secret)
-    EXPLORATION_GITHUB_ID: "94e8376d3a90429aeaea"
-    EXPLORATION_GITHUB_SECRET: $(exploration-github-client-secret)
-    VSO_GITHUB_ID: "3d4be8f37a0325b5817d"
-    VSO_GITHUB_SECRET: $(vso-github-client-secret)
-    VSO_PPE_GITHUB_ID: "eabf35024dc2e891a492"
-    VSO_PPE_GITHUB_SECRET: $(vso-ppe-github-client-secret)
-    VSO_DEV_GITHUB_ID: "84383ebd8a7c5f5efc5c"
-    VSO_DEV_GITHUB_SECRET: $(vso-dev-github-client-secret)
-    GITHUB_APP_ID: "Iv1.ae51e546bef24ff1"
-    GITHUB_APP_SECRET: $(github-app-client-secret)
-  condition: and(succeeded(), ne(variables['CacheExists-Compilation'], 'true'), ne(variables['CacheRestored'], 'true'))
-
 - script: |
     set -e
     yarn postinstall
 
@@ -44,8 +44,6 @@ export class GitHubAuthenticationProvider {
 			// Ignore, network request failed
 		}
 
-		// TODO revert Cannot validate tokens from auth server, no available clientId
-		// await this.validateSessions();
 		this.pollForChange();
 	}
 
@@ -144,22 +142,12 @@ export class GitHubAuthenticationProvider {
 	}
 
 	public async login(scopes: string): Promise<vscode.AuthenticationSession2> {
-		const token = scopes === 'vso' ? await this.loginAndInstallApp(scopes) : await this._githubServer.login(scopes);
+		const token = await this._githubServer.login(scopes);
 		const session = await this.tokenToSession(token, scopes.split(' '));
 		await this.setToken(session);
 		return session;
 	}
 
-	public async loginAndInstallApp(scopes: string): Promise<string> {
-		const token = await this._githubServer.login(scopes);
-		const hasUserInstallation = await this._githubServer.hasUserInstallation(token);
-		if (hasUserInstallation) {
-			return token;
-		} else {
-			return this._githubServer.installApp();
-		}
-	}
-
 	public async manuallyProvideToken(): Promise<void> {
 		this._githubServer.manuallyProvideToken();
 	}
@@ -184,14 +172,6 @@ export class GitHubAuthenticationProvider {
 		const sessionIndex = this._sessions.findIndex(session => session.id === id);
 		if (sessionIndex > -1) {
 			this._sessions.splice(sessionIndex, 1);
-			// TODO revert
-			// Cannot revoke tokens from auth server, no clientId available
-			// const token = await session.getAccessToken();
-			// try {
-			// 	await this._githubServer.revokeToken(token);
-			// } catch (_) {
-			// 	// ignore, should still remove from keychain
-			// }
 		}
 
 		await this.storeSessions();