Add tests for deducing extension kind

alexdima · alexdima · commit 98e653e82cd0 · 2020-07-24T10:41:04.000+02:00
diff --git a/src/vs/workbench/services/extensions/common/extensionsUtil.ts b/src/vs/workbench/services/extensions/common/extensionsUtil.ts
@@ -59,6 +59,10 @@ export function getExtensionKind(manifest: IExtensionManifest, productService: I
 		return toArray(result);
 	}
 
+	return deduceExtensionKind(manifest);
+}
+
+export function deduceExtensionKind(manifest: IExtensionManifest): ExtensionKind[] {
 	// Not an UI extension if it has main
 	if (manifest.main) {
 		if (manifest.browser) {
diff --git a/src/vs/workbench/services/extensions/test/common/extensionsUtil.test.ts b/src/vs/workbench/services/extensions/test/common/extensionsUtil.test.ts
@@ -0,0 +1,43 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as assert from 'assert';
+import { deduceExtensionKind } from 'vs/workbench/services/extensions/common/extensionsUtil';
+import { IExtensionManifest, ExtensionKind } from 'vs/platform/extensions/common/extensions';
+
+suite('ExtensionKind', () => {
+
+	function check(manifest: Partial<IExtensionManifest>, expected: ExtensionKind[]): void {
+		assert.deepEqual(deduceExtensionKind(<IExtensionManifest>manifest), expected);
+	}
+
+	test('declarative with extension dependencies => workspace', () => {
+		check({ extensionDependencies: ['ext1'] }, ['workspace']);
+	});
+
+	test('declarative extension pack => workspace', () => {
+		check({ extensionPack: ['ext1', 'ext2'] }, ['workspace']);
+	});
+
+	test('declarative with unknown contribution point => workspace', () => {
+		check({ contributes: <any>{ 'unknownPoint': { something: true } } }, ['workspace']);
+	});
+
+	test('simple declarative => ui, workspace, web', () => {
+		check({}, ['ui', 'workspace', 'web']);
+	});
+
+	test('only browser => web', () => {
+		check({ browser: 'main.browser.js' }, ['web']);
+	});
+
+	test('only main => workspace', () => {
+		check({ main: 'main.js' }, ['workspace']);
+	});
+
+	test('main and browser => workspace, web', () => {
+		check({ main: 'main.js', browser: 'main.browser.js' }, ['workspace', 'web']);
+	});
+});
