panel: set hidden same way we do for sidebar

isidorn · isidorn · commit 97ddcf622059 · 2016-09-06T13:49:32.000+02:00
microsoft#11436
diff --git a/src/vs/workbench/browser/parts/panel/panelPart.ts b/src/vs/workbench/browser/parts/panel/panelPart.ts
@@ -9,7 +9,7 @@ import {TPromise} from 'vs/base/common/winjs.base';
 import {KeyMod, KeyCode} from 'vs/base/common/keyCodes';
 import {Action, IAction} from 'vs/base/common/actions';
 import Event from 'vs/base/common/event';
-import {Dimension,Builder} from 'vs/base/browser/builder';
+import {Builder} from 'vs/base/browser/builder';
 import {Registry} from 'vs/platform/platform';
 import {Scope} from 'vs/workbench/browser/actionBarRegistry';
 import {SyncActionDescriptor} from 'vs/platform/actions/common/actions';
@@ -106,13 +106,6 @@ export class PanelPart extends CompositePart<Panel> implements IPanelService {
 	public hideActivePanel(): TPromise<void> {
 		return this.hideActiveComposite().then(composite => void 0);
 	}
-
-	layout(dimension: Dimension): Dimension[] {
-		const container = this.getContainer().getHTMLElement();
-		container.style.display = dimension.height === 0 ? 'none' : 'block';
-
-		return super.layout(dimension);
-	}
 }
 
 
diff --git a/src/vs/workbench/browser/parts/sidebar/media/sidebarpart.css b/src/vs/workbench/browser/parts/sidebar/media/sidebarpart.css
@@ -20,6 +20,11 @@
 	visibility: hidden !important;
 }
 
+.monaco-workbench.nopanel > .panel {
+	display: none !important;
+	visibility: hidden !important;
+}
+
 .monaco-workbench .viewlet .collapsible.header .title {
 	overflow: hidden;
 	text-overflow: ellipsis;
diff --git a/src/vs/workbench/electron-browser/workbench.ts b/src/vs/workbench/electron-browser/workbench.ts
@@ -555,6 +555,13 @@ export class Workbench implements IPartService {
 	public setPanelHidden(hidden: boolean, skipLayout?: boolean): void {
 		this.panelHidden = hidden;
 
+		// Adjust CSS
+		if (hidden) {
+			this.workbench.addClass('nopanel');
+		} else {
+			this.workbench.removeClass('nopanel');
+		}
+
 		// Layout
 		if (!skipLayout) {
 			this.workbenchLayout.layout(true);
@@ -713,6 +720,9 @@ export class Workbench implements IPartService {
 		if (this.sideBarHidden) {
 			this.workbench.addClass('nosidebar');
 		}
+		if (this.panelHidden) {
+			this.workbench.addClass('nopanel');
+		}
 
 		// Apply no-workspace state as CSS class
 		if (!this.workbenchParams.workspace) {
