fixes microsoft#90732

joaomoreno · joaomoreno · commit 86d575f8701f · 2020-07-01T10:03:54.000+02:00
diff --git a/src/vs/workbench/contrib/outline/browser/outlinePane.ts b/src/vs/workbench/contrib/outline/browser/outlinePane.ts
@@ -564,7 +564,7 @@ export class OutlinePane extends ViewPane {
 				return;
 			}
 
-			this._revealTreeSelection(newModel, e.element, !e.editorOptions.preserveFocus || !!e.editorOptions.pinned, e.sideBySide);
+			this._revealTreeSelection(newModel, e.element, !!e.editorOptions.preserveFocus || !e.editorOptions.pinned, e.sideBySide);
 		}));
 
 		// feature: reveal editor selection in outline
@@ -618,12 +618,12 @@ export class OutlinePane extends ViewPane {
 		}));
 	}
 
-	private async _revealTreeSelection(model: OutlineModel, element: OutlineElement, focus: boolean, aside: boolean): Promise<void> {
+	private async _revealTreeSelection(model: OutlineModel, element: OutlineElement, preserveFocus: boolean, aside: boolean): Promise<void> {
 		await this._editorService.openCodeEditor(
 			{
 				resource: model.uri,
 				options: {
-					preserveFocus: !focus,
+					preserveFocus,
 					selection: Range.collapseToStart(element.symbol.selectionRange),
 					selectionRevealType: TextEditorSelectionRevealType.NearTopIfOutsideViewport,
 				}

Original file line number	Diff line number	Diff line change
`@@ -564,7 +564,7 @@ export class OutlinePane extends ViewPane {`
`564`	`564`	`return;`
`565`	`565`	`}`
`566`	`566`
`567`		`- this._revealTreeSelection(newModel, e.element, !e.editorOptions.preserveFocus \|\| !!e.editorOptions.pinned, e.sideBySide);`
	`567`	`+ this._revealTreeSelection(newModel, e.element, !!e.editorOptions.preserveFocus \|\| !e.editorOptions.pinned, e.sideBySide);`
`568`	`568`	`}));`
`569`	`569`
`570`	`570`	`// feature: reveal editor selection in outline`
`@@ -618,12 +618,12 @@ export class OutlinePane extends ViewPane {`
`618`	`618`	`}));`
`619`	`619`	`}`
`620`	`620`
`621`		`- private async _revealTreeSelection(model: OutlineModel, element: OutlineElement, focus: boolean, aside: boolean): Promise<void> {`
	`621`	`+ private async _revealTreeSelection(model: OutlineModel, element: OutlineElement, preserveFocus: boolean, aside: boolean): Promise<void> {`
`622`	`622`	`await this._editorService.openCodeEditor(`
`623`	`623`	`{`
`624`	`624`	`resource: model.uri,`
`625`	`625`	`options: {`
`626`		`- preserveFocus: !focus,`
	`626`	`+ preserveFocus,`
`627`	`627`	`selection: Range.collapseToStart(element.symbol.selectionRange),`
`628`	`628`	`selectionRevealType: TextEditorSelectionRevealType.NearTopIfOutsideViewport,`
`629`	`629`	`}`