Fixes microsoft/monaco-editor#2144

alexdima · alexdima · commit 74c7f2b3d2a1 · 2020-09-24T16:09:38.000+02:00
diff --git a/src/vs/editor/contrib/quickAccess/gotoSymbolQuickAccess.ts b/src/vs/editor/contrib/quickAccess/gotoSymbolQuickAccess.ts
@@ -27,7 +27,7 @@ export interface IGotoSymbolQuickPickItem extends IQuickPickItem {
 }
 
 export interface IGotoSymbolQuickAccessProviderOptions extends IEditorNavigationQuickAccessOptions {
-	openSideBySideDirection: () => undefined | 'right' | 'down'
+	openSideBySideDirection?: () => undefined | 'right' | 'down'
 }
 
 export abstract class AbstractGotoSymbolQuickAccessProvider extends AbstractEditorNavigationQuickAccessProvider {
@@ -306,7 +306,7 @@ export abstract class AbstractGotoSymbolQuickAccessProvider extends AbstractEdit
 				},
 				strikethrough: deprecated,
 				buttons: (() => {
-					const openSideBySideDirection = this.options?.openSideBySideDirection();
+					const openSideBySideDirection = this.options?.openSideBySideDirection ? this.options?.openSideBySideDirection() : undefined;
 					if (!openSideBySideDirection) {
 						return undefined;
 					}

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ export interface IGotoSymbolQuickPickItem extends IQuickPickItem {`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`export interface IGotoSymbolQuickAccessProviderOptions extends IEditorNavigationQuickAccessOptions {`
`30`		`- openSideBySideDirection: () => undefined \| 'right' \| 'down'`
	`30`	`+ openSideBySideDirection?: () => undefined \| 'right' \| 'down'`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`export abstract class AbstractGotoSymbolQuickAccessProvider extends AbstractEditorNavigationQuickAccessProvider {`
`@@ -306,7 +306,7 @@ export abstract class AbstractGotoSymbolQuickAccessProvider extends AbstractEdit`
`306`	`306`	`},`
`307`	`307`	`strikethrough: deprecated,`
`308`	`308`	`buttons: (() => {`
`309`		`- const openSideBySideDirection = this.options?.openSideBySideDirection();`
	`309`	`+ const openSideBySideDirection = this.options?.openSideBySideDirection ? this.options?.openSideBySideDirection() : undefined;`
`310`	`310`	`if (!openSideBySideDirection) {`
`311`	`311`	`return undefined;`
`312`	`312`	`}`