[json] improve folding stability with comments

aeschli · aeschli · commit 3a9e9602d4cb · 2018-03-13T09:50:11.000+01:00
diff --git a/extensions/json/client/src/jsonMain.ts b/extensions/json/client/src/jsonMain.ts
@@ -70,7 +70,7 @@ export function activate(context: ExtensionContext) {
 	// The server is implemented in node
 	let serverModule = context.asAbsolutePath(path.join('server', 'out', 'jsonServerMain.js'));
 	// The debug options for the server
-	let debugOptions = { execArgv: ['--nolazy', '--inspect=6046'] };
+	let debugOptions = { execArgv: ['--nolazy', '--inspect=' + (9000 + Math.round(Math.random() * 10000))] };
 
 	// If the extension is launch in debug mode the debug server options are use
 	// Otherwise the run options are used
diff --git a/extensions/json/language-configuration.json b/extensions/json/language-configuration.json
@@ -12,6 +12,7 @@
 		{ "open": "[", "close": "]", "notIn": ["string"] },
 		{ "open": "(", "close": ")", "notIn": ["string"] },
 		{ "open": "'", "close": "'", "notIn": ["string"] },
+		{ "open": "/*", "close": "*/", "notIn": ["string"] },
 		{ "open": "\"", "close": "\"", "notIn": ["string", "comment"] },
 		{ "open": "`", "close": "`", "notIn": ["string", "comment"] }
 	]
diff --git a/extensions/json/server/src/jsonServerMain.ts b/extensions/json/server/src/jsonServerMain.ts
@@ -7,7 +7,7 @@
 import {
 	createConnection, IConnection,
 	TextDocuments, TextDocument, InitializeParams, InitializeResult, NotificationType, RequestType,
-	DocumentRangeFormattingRequest, Disposable, ServerCapabilities, DocumentColorRequest, ColorPresentationRequest,
+	DocumentRangeFormattingRequest, Disposable, ServerCapabilities, DocumentColorRequest, ColorPresentationRequest, Position,
 } from 'vscode-languageserver';
 
 import { xhr, XHRResponse, configure as configureHttpRequests, getErrorStatusDescription } from 'request-light';
@@ -18,7 +18,7 @@ import Strings = require('./utils/strings');
 import { formatError, runSafe, runSafeAsync } from './utils/errors';
 import { JSONDocument, JSONSchema, getLanguageService, DocumentLanguageSettings, SchemaConfiguration } from 'vscode-json-languageservice';
 import { getLanguageModelCache } from './languageModelCache';
-import { createScanner, SyntaxKind } from 'jsonc-parser';
+import { createScanner, SyntaxKind, ScanError } from 'jsonc-parser';
 
 import { FoldingRangeType, FoldingRangesRequest, FoldingRange, FoldingRangeList, FoldingProviderServerCapabilities } from './protocol/foldingProvider.proposed';
 
@@ -393,9 +393,13 @@ connection.onRequest(FoldingRangesRequest.type, params => {
 					case SyntaxKind.BlockCommentTrivia: {
 						let startLine = document.positionAt(scanner.getTokenOffset()).line;
 						let endLine = document.positionAt(scanner.getTokenOffset() + scanner.getTokenLength()).line;
-						if (startLine < endLine) {
-							ranges.push({ startLine, endLine, type: FoldingRangeType.Comment });
-							prevStart = startLine;
+						if (scanner.getTokenError() === ScanError.UnexpectedEndOfComment && startLine + 1 < document.lineCount) {
+							scanner.setPosition(document.offsetAt(Position.create(startLine + 1, 0)));
+						} else {
+							if (startLine < endLine) {
+								ranges.push({ startLine, endLine, type: FoldingRangeType.Comment });
+								prevStart = startLine;
+							}
 						}
 						break;
 					}

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`{ "open": "[", "close": "]", "notIn": ["string"] },`
`13`	`13`	`{ "open": "(", "close": ")", "notIn": ["string"] },`
`14`	`14`	`{ "open": "'", "close": "'", "notIn": ["string"] },`
	`15`	`+ { "open": "/", "close": "/", "notIn": ["string"] },`
`15`	`16`	`{ "open": "\"", "close": "\"", "notIn": ["string", "comment"] },`
`16`	`17`	{ "open": "`", "close": "`", "notIn": ["string", "comment"] }
`17`	`18`	`]`