[html] improve color decorator updating

aeschli · aeschli · commit 3358b269680f · 2017-01-19T16:41:54.000+01:00
diff --git a/extensions/html/client/src/colorDecorators.ts b/extensions/html/client/src/colorDecorators.ts
@@ -32,24 +32,20 @@ export function activateColorDecorations(decoratorProvider: (uri: string) => The
 
 	let pendingUpdateRequests: { [key: string]: NodeJS.Timer; } = {};
 
-	// we care about all visible editors
-	window.visibleTextEditors.forEach(editor => {
-		if (editor.document) {
-			triggerUpdateDecorations(editor.document);
-		}
-	});
-	// to get visible one has to become active
-	window.onDidChangeActiveTextEditor(editor => {
-		if (editor) {
+	window.onDidChangeVisibleTextEditors(editors => {
+		for (let editor of editors) {
 			triggerUpdateDecorations(editor.document);
 		}
 	}, null, disposables);
 
 	workspace.onDidChangeTextDocument(event => triggerUpdateDecorations(event.document), null, disposables);
-	workspace.onDidOpenTextDocument(triggerUpdateDecorations, null, disposables);
-	workspace.onDidCloseTextDocument(triggerUpdateDecorations, null, disposables);
 
-	workspace.textDocuments.forEach(triggerUpdateDecorations);
+	// we care about all visible editors
+	window.visibleTextEditors.forEach(editor => {
+		if (editor.document) {
+			triggerUpdateDecorations(editor.document);
+		}
+	});
 
 	function triggerUpdateDecorations(document: TextDocument) {
 		let triggerUpdate = supportedLanguages[document.languageId];
@@ -78,6 +74,7 @@ export function activateColorDecorations(decoratorProvider: (uri: string) => The
 		decoratorProvider(contentUri).then(ranges => {
 			for (let editor of window.visibleTextEditors) {
 				let document = editor.document;
+
 				if (document && document.version === documentVersion && contentUri === document.uri.toString()) {
 					let decorations = ranges.slice(0, MAX_DECORATORS).map(range => {
 						let color = document.getText(range);
