faster check for empty model

Benjamin Pasero · Benjamin Pasero · commit 2bb55b7cff44 · 2016-09-06T15:21:45.000+02:00
diff --git a/src/vs/workbench/common/editor/untitledEditorModel.ts b/src/vs/workbench/common/editor/untitledEditorModel.ts
@@ -9,7 +9,6 @@ import {TPromise} from 'vs/base/common/winjs.base';
 import {EditorModel, IEncodingSupport} from 'vs/workbench/common/editor';
 import {StringEditorModel} from 'vs/workbench/common/editor/stringEditorModel';
 import URI from 'vs/base/common/uri';
-import {IModelContentChangedEvent2} from 'vs/editor/common/editorCommon';
 import {EventType, EndOfLinePreference} from 'vs/editor/common/editorCommon';
 import {EventType as WorkbenchEventType, ResourceEvent} from 'vs/workbench/common/events';
 import {IFilesConfiguration} from 'vs/platform/files/common/files';
@@ -123,7 +122,7 @@ export class UntitledEditorModel extends StringEditorModel implements IEncodingS
 			this.configuredEncoding = configuration && configuration.files && configuration.files.encoding;
 
 			// Listen to content changes
-			this.textModelChangeListener = this.textEditorModel.onDidChangeContent(e => this.onModelContentChanged(e));
+			this.textModelChangeListener = this.textEditorModel.onDidChangeContent(e => this.onModelContentChanged());
 
 			// Emit initial dirty event if we are
 			if (this.dirty) {
@@ -136,7 +135,7 @@ export class UntitledEditorModel extends StringEditorModel implements IEncodingS
 		});
 	}
 
-	private onModelContentChanged(e:IModelContentChangedEvent2): void {
+	private onModelContentChanged(): void {
 
 		// turn dirty if we were not
 		if (!this.dirty) {
@@ -146,7 +145,7 @@ export class UntitledEditorModel extends StringEditorModel implements IEncodingS
 
 		// mark the untitled editor as non-dirty once its content becomes empty and we do
 		// not have an associated path set
-		else if (!this.hasAssociatedFilePath && !e.text && this.textEditorModel.getValueLength() === 0) {
+		else if (!this.hasAssociatedFilePath && this.textEditorModel.getLineCount() === 1 && this.textEditorModel.getLineContent(1) === '') {
 			this.dirty = false;
 			this._onDidChangeDirty.fire();
 		}
