Don't show the output panel in jake and grunt extensions

alexr00 · alexr00 · commit 1386fba3be3d · 2018-12-20T14:54:55.000+01:00
Fixes microsoft#64900
diff --git a/extensions/grunt/src/main.ts b/extensions/grunt/src/main.ts
@@ -59,6 +59,12 @@ function getOutputChannel(): vscode.OutputChannel {
 	return _channel;
 }
 
+function showError() {
+	vscode.window.showWarningMessage(localize('gulpTaskDetectError', 'Problem finding jake tasks. See the output for more information.'),
+		localize('jakeShowOutput', 'Go to output')).then(() => {
+			getOutputChannel().show(true);
+		});
+}
 interface GruntTaskDefinition extends vscode.TaskDefinition {
 	task: string;
 	file?: string;
@@ -120,7 +126,7 @@ class FolderDetector {
 			let { stdout, stderr } = await exec(commandLine, { cwd: rootPath });
 			if (stderr) {
 				getOutputChannel().appendLine(stderr);
-				getOutputChannel().show(true);
+				showError();
 			}
 			let result: vscode.Task[] = [];
 			if (stdout) {
@@ -186,7 +192,7 @@ class FolderDetector {
 				channel.appendLine(err.stdout);
 			}
 			channel.appendLine(localize('execFailed', 'Auto detecting Grunt for folder {0} failed with error: {1}', this.workspaceFolder.name, err.error ? err.error.toString() : 'unknown'));
-			channel.show(true);
+			showError();
 			return emptyTasks;
 		}
 	}
diff --git a/extensions/jake/src/main.ts b/extensions/jake/src/main.ts
@@ -59,6 +59,13 @@ function getOutputChannel(): vscode.OutputChannel {
 	return _channel;
 }
 
+function showError() {
+	vscode.window.showWarningMessage(localize('gulpTaskDetectError', 'Problem finding jake tasks. See the output for more information.'),
+		localize('jakeShowOutput', 'Go to output')).then(() => {
+			getOutputChannel().show(true);
+		});
+}
+
 interface JakeTaskDefinition extends vscode.TaskDefinition {
 	task: string;
 	file?: string;
@@ -124,7 +131,7 @@ class FolderDetector {
 			let { stdout, stderr } = await exec(commandLine, { cwd: rootPath });
 			if (stderr) {
 				getOutputChannel().appendLine(stderr);
-				getOutputChannel().show(true);
+				showError();
 			}
 			let result: vscode.Task[] = [];
 			if (stdout) {
@@ -163,7 +170,7 @@ class FolderDetector {
 				channel.appendLine(err.stdout);
 			}
 			channel.appendLine(localize('execFailed', 'Auto detecting Jake for folder {0} failed with error: {1}', this.workspaceFolder.name, err.error ? err.error.toString() : 'unknown'));
-			channel.show(true);
+			showError();
 			return emptyTasks;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,12 @@ function getOutputChannel(): vscode.OutputChannel {`
`59`	`59`	`return _channel;`
`60`	`60`	`}`
`61`	`61`
	`62`	`+function showError() {`
	`63`	`+ vscode.window.showWarningMessage(localize('gulpTaskDetectError', 'Problem finding jake tasks. See the output for more information.'),`
	`64`	`+ localize('jakeShowOutput', 'Go to output')).then(() => {`
	`65`	`+ getOutputChannel().show(true);`
	`66`	`+ });`
	`67`	`+}`
`62`	`68`	`interface GruntTaskDefinition extends vscode.TaskDefinition {`
`63`	`69`	`task: string;`
`64`	`70`	`file?: string;`
`@@ -120,7 +126,7 @@ class FolderDetector {`
`120`	`126`	`let { stdout, stderr } = await exec(commandLine, { cwd: rootPath });`
`121`	`127`	`if (stderr) {`
`122`	`128`	`getOutputChannel().appendLine(stderr);`
`123`		`- getOutputChannel().show(true);`
	`129`	`+ showError();`
`124`	`130`	`}`
`125`	`131`	`let result: vscode.Task[] = [];`
`126`	`132`	`if (stdout) {`
`@@ -186,7 +192,7 @@ class FolderDetector {`
`186`	`192`	`channel.appendLine(err.stdout);`
`187`	`193`	`}`
`188`	`194`	`channel.appendLine(localize('execFailed', 'Auto detecting Grunt for folder {0} failed with error: {1}', this.workspaceFolder.name, err.error ? err.error.toString() : 'unknown'));`
`189`		`- channel.show(true);`
	`195`	`+ showError();`
`190`	`196`	`return emptyTasks;`
`191`	`197`	`}`
`192`	`198`	`}`
Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,13 @@ function getOutputChannel(): vscode.OutputChannel {`
`59`	`59`	`return _channel;`
`60`	`60`	`}`
`61`	`61`
	`62`	`+function showError() {`
	`63`	`+ vscode.window.showWarningMessage(localize('gulpTaskDetectError', 'Problem finding jake tasks. See the output for more information.'),`
	`64`	`+ localize('jakeShowOutput', 'Go to output')).then(() => {`
	`65`	`+ getOutputChannel().show(true);`
	`66`	`+ });`
	`67`	`+}`
	`68`	`+`
`62`	`69`	`interface JakeTaskDefinition extends vscode.TaskDefinition {`
`63`	`70`	`task: string;`
`64`	`71`	`file?: string;`
`@@ -124,7 +131,7 @@ class FolderDetector {`
`124`	`131`	`let { stdout, stderr } = await exec(commandLine, { cwd: rootPath });`
`125`	`132`	`if (stderr) {`
`126`	`133`	`getOutputChannel().appendLine(stderr);`
`127`		`- getOutputChannel().show(true);`
	`134`	`+ showError();`
`128`	`135`	`}`
`129`	`136`	`let result: vscode.Task[] = [];`
`130`	`137`	`if (stdout) {`
`@@ -163,7 +170,7 @@ class FolderDetector {`
`163`	`170`	`channel.appendLine(err.stdout);`
`164`	`171`	`}`
`165`	`172`	`channel.appendLine(localize('execFailed', 'Auto detecting Jake for folder {0} failed with error: {1}', this.workspaceFolder.name, err.error ? err.error.toString() : 'unknown'));`
`166`		`- channel.show(true);`
	`173`	`+ showError();`
`167`	`174`	`return emptyTasks;`
`168`	`175`	`}`
`169`	`176`	`}`