Fix microsoft#54256 - only sort file search results when a pattern is specified

roblourens · roblourens · commit 09e26ac36f67 · 2018-07-13T10:26:58.000-07:00
diff --git a/extensions/search-rg/src/cachedSearchProvider.ts b/extensions/search-rg/src/cachedSearchProvider.ts
@@ -74,8 +74,13 @@ export class CachedSearchProvider {
 		}
 
 		return allResultsPromise.then(results => {
-			const scorerCache: ScorerCache = cache ? cache.scorerCache : Object.create(null);
-			return this.sortResults(args, results, scorerCache);
+			// TODO@roblou quickopen results are not scored until the first keypress
+			if (args.query.pattern) {
+				const scorerCache: ScorerCache = cache ? cache.scorerCache : Object.create(null);
+				return this.sortResults(args, results, scorerCache);
+			} else {
+				return results;
+			}
 		});
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -74,8 +74,13 @@ export class CachedSearchProvider {`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`return allResultsPromise.then(results => {`
`77`		`- const scorerCache: ScorerCache = cache ? cache.scorerCache : Object.create(null);`
`78`		`- return this.sortResults(args, results, scorerCache);`
	`77`	`+ // TODO@roblou quickopen results are not scored until the first keypress`
	`78`	`+ if (args.query.pattern) {`
	`79`	`+ const scorerCache: ScorerCache = cache ? cache.scorerCache : Object.create(null);`
	`80`	`+ return this.sortResults(args, results, scorerCache);`
	`81`	`+ } else {`
	`82`	`+ return results;`
	`83`	`+ }`
`79`	`84`	`});`
`80`	`85`	`}`
`81`	`86`