back to ATOM_SHELL_INTERNAL_RUN_AS_NODE

Benjamin Pasero · Benjamin Pasero · commit 0525466708af · 2016-07-08T16:12:10.000+02:00
diff --git a/appveyor.yml b/appveyor.yml
@@ -1,5 +1,5 @@
 environment:
-  ELECTRON_RUN_AS_NODE: 1
+  ATOM_SHELL_INTERNAL_RUN_AS_NODE: 1
 
 install:
   - ps: Install-Product node 5.10.1 x64
diff --git a/extensions/typescript/src/utils/electron.ts b/extensions/typescript/src/utils/electron.ts
@@ -48,7 +48,7 @@ function generatePatchedEnv(env:any, stdInPipeName:string, stdOutPipeName:string
 	newEnv['STDIN_PIPE_NAME'] = stdInPipeName;
 	newEnv['STDOUT_PIPE_NAME'] = stdOutPipeName;
 	newEnv['STDERR_PIPE_NAME'] = stdErrPipeName;
-	newEnv['ELECTRON_RUN_AS_NODE'] = '1';
+	newEnv['ATOM_SHELL_INTERNAL_RUN_AS_NODE'] = '1';
 
 	return newEnv;
 }
diff --git a/extensions/typescript/src/utils/electronForkStart.ts b/extensions/typescript/src/utils/electronForkStart.ts
@@ -31,7 +31,7 @@ var stdErrPipeName = process.env['STDERR_PIPE_NAME'];
 log('STDIN_PIPE_NAME: ' + stdInPipeName);
 log('STDOUT_PIPE_NAME: ' + stdOutPipeName);
 log('STDERR_PIPE_NAME: ' + stdErrPipeName);
-log('ELECTRON_RUN_AS_NODE: ' + process.env['ELECTRON_RUN_AS_NODE']);
+log('ATOM_SHELL_INTERNAL_RUN_AS_NODE: ' + process.env['ATOM_SHELL_INTERNAL_RUN_AS_NODE']);
 
 // stdout redirection to named pipe
 (function() {
@@ -147,7 +147,7 @@ log('ELECTRON_RUN_AS_NODE: ' + process.env['ELECTRON_RUN_AS_NODE']);
 		delete process.env['STDIN_PIPE_NAME'];
 		delete process.env['STDOUT_PIPE_NAME'];
 		delete process.env['STDERR_PIPE_NAME'];
-		delete process.env['ELECTRON_RUN_AS_NODE'];
+		delete process.env['ATOM_SHELL_INTERNAL_RUN_AS_NODE'];
 
 		require(program);
 
diff --git a/resources/darwin/bin/code.sh b/resources/darwin/bin/code.sh
@@ -7,5 +7,5 @@ function realpath() { /usr/bin/python -c "import os,sys; print os.path.realpath(
 CONTENTS="$(dirname "$(dirname "$(dirname "$(dirname "$(realpath "$0")")")")")"
 ELECTRON="$CONTENTS/MacOS/Electron"
 CLI="$CONTENTS/Resources/app/out/cli.js"
-ELECTRON_RUN_AS_NODE=1 "$ELECTRON" "$CLI" "$@"
+ATOM_SHELL_INTERNAL_RUN_AS_NODE=1 "$ELECTRON" "$CLI" "$@"
 exit $?
diff --git a/resources/linux/bin/code.sh b/resources/linux/bin/code.sh
@@ -33,5 +33,5 @@ fi
 
 ELECTRON="$VSCODE_PATH/@@NAME@@"
 CLI="$VSCODE_PATH/resources/app/out/cli.js"
-ELECTRON_RUN_AS_NODE=1 "$ELECTRON" "$CLI" "$@"
+ATOM_SHELL_INTERNAL_RUN_AS_NODE=1 "$ELECTRON" "$CLI" "$@"
 exit $?
diff --git a/resources/win32/bin/code.cmd b/resources/win32/bin/code.cmd
@@ -1,6 +1,6 @@
 @echo off
 setlocal
 set VSCODE_DEV=
-set ELECTRON_RUN_AS_NODE=1
+set ATOM_SHELL_INTERNAL_RUN_AS_NODE=1
 call "%~dp0..\@@NAME@@.exe" "%~dp0..\resources\\app\\out\\cli.js" %*
 endlocal
diff --git a/resources/win32/bin/code.sh b/resources/win32/bin/code.sh
@@ -7,5 +7,5 @@ NAME="@@NAME@@"
 VSCODE_PATH="$(dirname "$(dirname "$(realpath "$0")")")"
 ELECTRON="$VSCODE_PATH/$NAME.exe"
 CLI="$VSCODE_PATH/resources/app/out/cli.js"
-ELECTRON_NO_ATTACH_CONSOLE=1 ELECTRON_RUN_AS_NODE=1 "$ELECTRON" "$CLI" "$@"
+ELECTRON_NO_ATTACH_CONSOLE=1 ATOM_SHELL_INTERNAL_RUN_AS_NODE=1 "$ELECTRON" "$CLI" "$@"
 exit $?
diff --git a/scripts/code-cli.sh b/scripts/code-cli.sh
@@ -26,7 +26,7 @@ function code() {
 
 	CLI="$ROOT/out/cli.js"
 
-	ELECTRON_RUN_AS_NODE=1 \
+	ATOM_SHELL_INTERNAL_RUN_AS_NODE=1 \
 	NODE_ENV=development \
 	VSCODE_DEV=1 \
 	ELECTRON_ENABLE_LOGGING=1 \
diff --git a/scripts/test-integration.bat b/scripts/test-integration.bat
@@ -4,7 +4,7 @@ setlocal
 rem APPVEYOR Builds
 if not "%APPVEYOR%" == "" (
 	set ELECTRON_NO_ATTACH_CONSOLE=1
-	set ELECTRON_RUN_AS_NODE=
+	set ATOM_SHELL_INTERNAL_RUN_AS_NODE=
 )
 
 :: Integration Tests
diff --git a/scripts/test.bat b/scripts/test.bat
@@ -1,7 +1,7 @@
 @echo off
 setlocal
 
-set ELECTRON_RUN_AS_NODE=1
+set ATOM_SHELL_INTERNAL_RUN_AS_NODE=1
 
 rem TFS Builds
 if not "%BUILD_BUILDID%" == "" (
diff --git a/scripts/test.sh b/scripts/test.sh
@@ -21,11 +21,11 @@ test -d out || ./node_modules/.bin/gulp compile
 
 # Unit Tests
 if [[ "$OSTYPE" == "darwin"* ]]; then
-	cd $ROOT ; ulimit -n 4096 ; ELECTRON_RUN_AS_NODE=1 \
+	cd $ROOT ; ulimit -n 4096 ; ATOM_SHELL_INTERNAL_RUN_AS_NODE=1 \
 		./.build/electron/Electron.app/Contents/MacOS/Electron \
 		node_modules/mocha/bin/_mocha $*
 else
-	cd $ROOT ; ELECTRON_RUN_AS_NODE=1 \
+	cd $ROOT ; ATOM_SHELL_INTERNAL_RUN_AS_NODE=1 \
 		./.build/electron/electron \
 		node_modules/mocha/bin/_mocha $*
 fi
diff --git a/src/vs/base/node/stdFork.ts b/src/vs/base/node/stdFork.ts
@@ -49,7 +49,7 @@ function generatePatchedEnv(env:any, stdInPipeName:string, stdOutPipeName:string
 	newEnv['STDIN_PIPE_NAME'] = stdInPipeName;
 	newEnv['STDOUT_PIPE_NAME'] = stdOutPipeName;
 	newEnv['STDERR_PIPE_NAME'] = stdErrPipeName;
-	newEnv['ELECTRON_RUN_AS_NODE'] = '1';
+	newEnv['ATOM_SHELL_INTERNAL_RUN_AS_NODE'] = '1';
 
 	return newEnv;
 }
diff --git a/src/vs/base/node/stdForkStart.js b/src/vs/base/node/stdForkStart.js
@@ -33,7 +33,7 @@ var stdErrPipeName = process.env['STDERR_PIPE_NAME'];
 log('STDIN_PIPE_NAME: ' + stdInPipeName);
 log('STDOUT_PIPE_NAME: ' + stdOutPipeName);
 log('STDERR_PIPE_NAME: ' + stdErrPipeName);
-log('ELECTRON_RUN_AS_NODE: ' + process.env['ELECTRON_RUN_AS_NODE']);
+log('ATOM_SHELL_INTERNAL_RUN_AS_NODE: ' + process.env['ATOM_SHELL_INTERNAL_RUN_AS_NODE']);
 
 // stdout redirection to named pipe
 (function() {
@@ -149,7 +149,7 @@ log('ELECTRON_RUN_AS_NODE: ' + process.env['ELECTRON_RUN_AS_NODE']);
 		delete process.env['STDIN_PIPE_NAME'];
 		delete process.env['STDOUT_PIPE_NAME'];
 		delete process.env['STDERR_PIPE_NAME'];
-		delete process.env['ELECTRON_RUN_AS_NODE'];
+		delete process.env['ATOM_SHELL_INTERNAL_RUN_AS_NODE'];
 
 		require(program);
 
diff --git a/src/vs/code/electron-main/main.ts b/src/vs/code/electron-main/main.ts
@@ -285,11 +285,11 @@ interface IEnv {
 
 function getUnixUserEnvironment(): TPromise<IEnv> {
 	const promise = new TPromise((c, e) => {
-		const runAsNode = process.env['ELECTRON_RUN_AS_NODE'];
+		const runAsNode = process.env['ATOM_SHELL_INTERNAL_RUN_AS_NODE'];
 		const noAttach = process.env['ELECTRON_NO_ATTACH_CONSOLE'];
 
 		const env = assign({}, process.env, {
-			ELECTRON_RUN_AS_NODE: '1',
+			ATOM_SHELL_INTERNAL_RUN_AS_NODE: '1',
 			ELECTRON_NO_ATTACH_CONSOLE: '1'
 		});
 
@@ -321,9 +321,9 @@ function getUnixUserEnvironment(): TPromise<IEnv> {
 				const env = JSON.parse(raw);
 
 				if (runAsNode) {
-					env['ELECTRON_RUN_AS_NODE'] = runAsNode;
+					env['ATOM_SHELL_INTERNAL_RUN_AS_NODE'] = runAsNode;
 				} else {
-					delete env['ELECTRON_RUN_AS_NODE'];
+					delete env['ATOM_SHELL_INTERNAL_RUN_AS_NODE'];
 				}
 
 				if (noAttach) {
diff --git a/src/vs/code/node/cli.ts b/src/vs/code/node/cli.ts
@@ -33,7 +33,7 @@ export function main(args: string[]): TPromise<void> {
 			'VSCODE_CLI': '1',
 			'ELECTRON_NO_ATTACH_CONSOLE': '1'
 		});
-		delete env['ELECTRON_RUN_AS_NODE'];
+		delete env['ATOM_SHELL_INTERNAL_RUN_AS_NODE'];
 
 		let options = {
 			detached: true,
diff --git a/src/vs/workbench/parts/debug/electron-browser/debugService.ts b/src/vs/workbench/parts/debug/electron-browser/debugService.ts
@@ -593,7 +593,7 @@ export class DebugService implements debug.IDebugService {
 						timeout: 1000 * 60 * 5,
 						args: [`${ publisher }.${ type }`, JSON.stringify(data), aiKey],
 						env: {
-							ELECTRON_RUN_AS_NODE: 1,
+							ATOM_SHELL_INTERNAL_RUN_AS_NODE: 1,
 							PIPE_LOGGING: 'true',
 							AMD_ENTRYPOINT: 'vs/workbench/parts/debug/node/telemetryApp'
 						}
diff --git a/src/vs/workbench/parts/git/electron-browser/electronGitService.ts b/src/vs/workbench/parts/git/electron-browser/electronGitService.ts
@@ -157,7 +157,7 @@ function createRemoteRawGitService(gitPath: string, workspaceRoot: string, encod
 					timeout: 1000 * 60,
 					args: [path, workspaceRoot, encoding, remote.process.execPath, version],
 					env: {
-						ELECTRON_RUN_AS_NODE: 1,
+						ATOM_SHELL_INTERNAL_RUN_AS_NODE: 1,
 						PIPE_LOGGING: 'true',
 						AMD_ENTRYPOINT: 'vs/workbench/parts/git/node/gitApp',
 						VERBOSE_LOGGING: String(verbose)
diff --git a/src/vs/workbench/parts/terminal/electron-browser/terminalProcess.js b/src/vs/workbench/parts/terminal/electron-browser/terminalProcess.js
@@ -63,7 +63,7 @@ function getArgs() {
 
 function cleanEnv() {
 	var keys = [
-		'ELECTRON_RUN_AS_NODE',
+		'ATOM_SHELL_INTERNAL_RUN_AS_NODE',
 		'PTYCWD',
 		'PTYPID',
 		'PTYSHELL'

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ function generatePatchedEnv(env:any, stdInPipeName:string, stdOutPipeName:string`
`48`	`48`	`newEnv['STDIN_PIPE_NAME'] = stdInPipeName;`
`49`	`49`	`newEnv['STDOUT_PIPE_NAME'] = stdOutPipeName;`
`50`	`50`	`newEnv['STDERR_PIPE_NAME'] = stdErrPipeName;`
`51`		`- newEnv['ELECTRON_RUN_AS_NODE'] = '1';`
	`51`	`+ newEnv['ATOM_SHELL_INTERNAL_RUN_AS_NODE'] = '1';`
`52`	`52`
`53`	`53`	`return newEnv;`
`54`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ setlocal`
`4`	`4`	`rem APPVEYOR Builds`
`5`	`5`	`if not "%APPVEYOR%" == "" (`
`6`	`6`	`set ELECTRON_NO_ATTACH_CONSOLE=1`
`7`		`- set ELECTRON_RUN_AS_NODE=`
	`7`	`+ set ATOM_SHELL_INTERNAL_RUN_AS_NODE=`
`8`	`8`	`)`
`9`	`9`
`10`	`10`	`:: Integration Tests`