README clarifications & nits (textileio#478)

jsign · web-flow · commit 878a416bfd27 · 2020-06-30T11:58:45.000-03:00
* improve cidlogger message

Signed-off-by: Ignacio Hagopian &lt;jsign.uy@gmail.com&gt;

* some readme clarifications

Signed-off-by: Ignacio Hagopian &lt;jsign.uy@gmail.com&gt;

* less restrictive Go versioning

Signed-off-by: Ignacio Hagopian &lt;jsign.uy@gmail.com&gt;

* reduce CI noise

Signed-off-by: Ignacio Hagopian &lt;jsign.uy@gmail.com&gt;
diff --git a/Makefile b/Makefile
@@ -21,7 +21,7 @@ docs-pow:
 .PHONY: docs-pow
 
 test:
-	go test -short -parallel 8 -race -timeout 30m ./... 
+	go test -short -parallel 6 -race -timeout 30m ./... 
 .PHONY: test
 
 clean-protos:
diff --git a/README.md b/README.md
@@ -14,6 +14,7 @@ Join us on our [public Slack channel](https://slack.textile.io/) for news, discu
 
 ## Table of Contents
 
+-   [Prerequisites](#prerequisites)
 -   [Design](#design)
 -   [Installation](#installation)
 -   [Devnet mode](#devnet-mode)
@@ -24,6 +25,10 @@ Join us on our [public Slack channel](https://slack.textile.io/) for news, discu
 -   [Changelog](#changelog)
 -   [License](#license)
 
+## Prerequisites
+
+To build from source, you need to have Go 1.14 or newer installed.
+
 ## Design
 
 Powergate is composed of different modules which can be used independently, and compose toegheter to provide other higher-level modules.
@@ -60,6 +65,7 @@ To build and install the CLI, run:
 ```bash
 $ make build-pow
 ```
+The binary will be placed automatically in `$GOPATH/bin` which in general is in `$PATH`, so you can immediately run `pow` in your terminal.
 
 You can read the [generated CLI docs](https://github.com/textileio/powergate/blob/master/cli-docs/pow/pow.md) in this repo, or run `pow` with the `--help` flag to see the available commands:
 
diff --git a/ffs/integrationtest/integration_test.go b/ffs/integrationtest/integration_test.go
@@ -1308,8 +1308,6 @@ func TestParallelExecution(t *testing.T) {
 }
 
 func TestJobCancellation(t *testing.T) {
-	t.Parallel()
-
 	r := rand.New(rand.NewSource(22))
 	ipfsAPI, _, fapi, cls := newAPI(t, 1)
 	defer cls()
diff --git a/ffs/scheduler/scheduler.go b/ffs/scheduler/scheduler.go
@@ -493,15 +493,15 @@ func (s *Scheduler) execute(ctx context.Context, a astore.Action, job ffs.Job) (
 
 func (s *Scheduler) executeHotStorage(ctx context.Context, curr ffs.CidInfo, cfg ffs.HotConfig, waddr string, replaceCid cid.Cid) (ffs.HotInfo, error) {
 	if cfg.Enabled == curr.Hot.Enabled {
-		s.l.Log(ctx, curr.Cid, "Current Cid state is healthy in Hot-Storage.")
+		s.l.Log(ctx, curr.Cid, "No actions needed in Hot Storage.")
 		return curr.Hot, nil
 	}
 
 	if !cfg.Enabled {
 		if err := s.hs.Remove(ctx, curr.Cid); err != nil {
 			return ffs.HotInfo{}, fmt.Errorf("removing from hot storage: %s", err)
 		}
-		s.l.Log(ctx, curr.Cid, "Cid successfully removed from Hot-Storage.")
+		s.l.Log(ctx, curr.Cid, "Cid successfully removed from Hot Storage.")
 		return ffs.HotInfo{Enabled: false}, nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1308,8 +1308,6 @@ func TestParallelExecution(t *testing.T) {`
`1308`	`1308`	`}`
`1309`	`1309`
`1310`	`1310`	`func TestJobCancellation(t *testing.T) {`
`1311`		`- t.Parallel()`
`1312`		`-`
`1313`	`1311`	`r := rand.New(rand.NewSource(22))`
`1314`	`1312`	`ipfsAPI, _, fapi, cls := newAPI(t, 1)`
`1315`	`1313`	`defer cls()`
Original file line number	Diff line number	Diff line change
`@@ -493,15 +493,15 @@ func (s *Scheduler) execute(ctx context.Context, a astore.Action, job ffs.Job) (`
`493`	`493`
`494`	`494`	`func (s *Scheduler) executeHotStorage(ctx context.Context, curr ffs.CidInfo, cfg ffs.HotConfig, waddr string, replaceCid cid.Cid) (ffs.HotInfo, error) {`
`495`	`495`	`if cfg.Enabled == curr.Hot.Enabled {`
`496`		`- s.l.Log(ctx, curr.Cid, "Current Cid state is healthy in Hot-Storage.")`
	`496`	`+ s.l.Log(ctx, curr.Cid, "No actions needed in Hot Storage.")`
`497`	`497`	`return curr.Hot, nil`
`498`	`498`	`}`
`499`	`499`
`500`	`500`	`if !cfg.Enabled {`
`501`	`501`	`if err := s.hs.Remove(ctx, curr.Cid); err != nil {`
`502`	`502`	`return ffs.HotInfo{}, fmt.Errorf("removing from hot storage: %s", err)`
`503`	`503`	`}`
`504`		`- s.l.Log(ctx, curr.Cid, "Cid successfully removed from Hot-Storage.")`
	`504`	`+ s.l.Log(ctx, curr.Cid, "Cid successfully removed from Hot Storage.")`
`505`	`505`	`return ffs.HotInfo{Enabled: false}, nil`
`506`	`506`	`}`
`507`	`507`