Throwing a specific error if backend returned non-zero code without output (runtimeverification#954)

traiansf · rv-jenkins · commit bb07eace48c7 · 2019-12-06T17:26:23.000-06:00
diff --git a/haskell-backend/src/main/java/org/kframework/backend/haskell/HaskellRewriter.java b/haskell-backend/src/main/java/org/kframework/backend/haskell/HaskellRewriter.java
@@ -138,6 +138,7 @@ public RewriterResult execute(K k, Optional<Integer> depth) {
                 try {
                     File korePath = koreDirectory == null ? null : new File(koreDirectory);
                     int execStatus = executeCommandBasic(korePath, koreCommand);
+                    checkOutput(koreOutputFile, execStatus);
                     K outputK = new KoreParser(mod.sortAttributesFor()).parseFile(koreOutputFile);
                     return new RewriterResult(Optional.empty(), Optional.of(execStatus), outputK);
                 } catch (IOException e) {
@@ -283,6 +284,7 @@ private RewriterResult executeKoreCommands(Module rules, String[] koreCommand,
                 try {
                     File korePath = koreDirectory == null ? null : new File(koreDirectory);
                     exit = executeCommandBasic(korePath, koreCommand);
+                    checkOutput(koreOutputFile, exit);
                 } catch (IOException e) {
                     throw KEMException.criticalError("I/O Error while executing", e);
                 } catch (InterruptedException e) {
@@ -383,6 +385,15 @@ public boolean equivalence(Rewriter firstDef, Rewriter secondDef, Module firstSp
         };
     }
 
+    private void checkOutput(File koreOutputFile, int execStatus) {
+        if (execStatus != 0) {
+            if (!koreOutputFile.isFile()) {
+                throw KEMException.criticalError("Haskell Backend execution failed with code " + execStatus
+                        + " and produced no output.");
+            }
+        }
+    }
+
     private String getKoreString(K initialConfiguration, Module mod, ModuleToKORE converter) {
         ExpandMacros macroExpander = ExpandMacros.forNonSentences(mod, files, kompileOptions, false);
         K withMacros = macroExpander.expand(initialConfiguration);
