test: fix test-tls-env-extra-ca-file-load

ebickle · addaleax · commit d53bcea2de4e · 2020-03-12T16:53:29.000+01:00
Fixes broken unit test for the NODE_EXTRA_CA_CERTS environment variable. Unit test was exiting without evaluating any assertions or running any tests. Fixes: nodejs#32072 PR-URL: nodejs#32073 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/test/parallel/test-tls-env-extra-ca-file-load.js b/test/parallel/test-tls-env-extra-ca-file-load.js
@@ -16,14 +16,7 @@ const { fork } = require('child_process');
 
 // This test ensures that extra certificates are loaded at startup.
 if (process.argv[2] !== 'child') {
-  if (process.env.CHILD_USE_EXTRA_CA_CERTS === 'yes') {
-    assert.strictEqual(binding.isExtraRootCertsFileLoaded(), true);
-  } else if (process.env.CHILD_USE_EXTRA_CA_CERTS === 'no') {
-    assert.strictEqual(binding.isExtraRootCertsFileLoaded(), false);
-    tls.createServer({});
-    assert.strictEqual(binding.isExtraRootCertsFileLoaded(), false);
-  }
-} else {
+  // Parent
   const NODE_EXTRA_CA_CERTS = fixtures.path('keys', 'ca1-cert.pem');
   const extendsEnv = (obj) => ({ ...process.env, ...obj });
 
@@ -37,4 +30,12 @@ if (process.argv[2] !== 'child') {
       assert.strictEqual(status, 0);
     }));
   });
+} else if (process.env.CHILD_USE_EXTRA_CA_CERTS === 'yes') {
+  // Child with extra certificates loaded at startup.
+  assert.strictEqual(binding.isExtraRootCertsFileLoaded(), true);
+} else {
+  // Child without extra certificates.
+  assert.strictEqual(binding.isExtraRootCertsFileLoaded(), false);
+  tls.createServer({});
+  assert.strictEqual(binding.isExtraRootCertsFileLoaded(), false);
 }
