node: fix throws before timer module is loaded

trevnorris · trevnorris · commit b1e9d330aa60 · 2014-12-05T04:52:19.000-08:00
An edge case could occur when the setImmediate() in _fatalException() would fire before the timers module had been loaded globally, causing Node to crash. PR-URL: nodejs/node-v0.x-archive#8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
diff --git a/src/node.js b/src/node.js
@@ -249,7 +249,7 @@
 
       // if we handled an error, then make sure any ticks get processed
       } else {
-        var t = setImmediate(process._tickCallback);
+        NativeModule.require('timers').setImmediate(process._tickCallback);
       }
 
       return caught;

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@`
`249`	`249`
`250`	`250`	`// if we handled an error, then make sure any ticks get processed`
`251`	`251`	`} else {`
`252`		`- var t = setImmediate(process._tickCallback);`
	`252`	`+ NativeModule.require('timers').setImmediate(process._tickCallback);`
`253`	`253`	`}`
`254`	`254`
`255`	`255`	`return caught;`