src: remove unnecessary calls to Local<T>::New()

bnoordhuis · bnoordhuis · commit 6acde2152fa5 · 2013-07-07T14:34:49.000+02:00
diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc
@@ -797,7 +797,7 @@ void AfterGetAddrInfo(uv_getaddrinfo_t* req, int status, struct addrinfo* res) {
   if (status) {
     // Error
     SetErrno(uv_last_error(uv_default_loop()));
-    argv[0] = Local<Value>::New(node_isolate, Null(node_isolate));
+    argv[0] = Null(node_isolate);
   } else {
     // Success
     struct addrinfo *address;
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -3227,12 +3227,12 @@ void EIO_PBKDF2(uv_work_t* work_req) {
 
 void EIO_PBKDF2After(pbkdf2_req* req, Local<Value> argv[2]) {
   if (req->err) {
-    argv[0] = Local<Value>::New(node_isolate, Undefined(node_isolate));
+    argv[0] = Undefined(node_isolate);
     argv[1] = Encode(req->key, req->keylen, BUFFER);
     memset(req->key, 0, req->keylen);
   } else {
     argv[0] = Exception::Error(String::New("PBKDF2 error"));
-    argv[1] = Local<Value>::New(node_isolate, Undefined(node_isolate));
+    argv[1] = Undefined(node_isolate);
   }
 
   delete[] req->pass;
@@ -3401,10 +3401,10 @@ void RandomBytesCheck(RandomBytesRequest* req, Local<Value> argv[2]) {
       ERR_error_string_n(req->error_, errmsg, sizeof errmsg);
 
     argv[0] = Exception::Error(String::New(errmsg));
-    argv[1] = Local<Value>::New(node_isolate, Null(node_isolate));
+    argv[1] = Null(node_isolate);
   }
   else {
-    argv[0] = Local<Value>::New(node_isolate, Null(node_isolate));
+    argv[0] = Null(node_isolate);
     argv[1] = Buffer::Use(req->data_, req->size_);
   }
 }
diff --git a/src/node_file.cc b/src/node_file.cc
@@ -121,7 +121,7 @@ static void After(uv_fs_t *req) {
     }
   } else {
     // error value is empty or null for non-error.
-    argv[0] = Local<Value>::New(node_isolate, Null(node_isolate));
+    argv[0] = Null(node_isolate);
 
     // All have at least two args now.
     argc = 2;
diff --git a/src/pipe_wrap.cc b/src/pipe_wrap.cc
@@ -248,8 +248,8 @@ void PipeWrap::AfterConnect(uv_connect_t* req, int status) {
     Integer::New(status, node_isolate),
     wrap->object(),
     req_wrap_obj,
-    Local<Value>::New(node_isolate, Boolean::New(readable)),
-    Local<Value>::New(node_isolate, Boolean::New(writable))
+    Boolean::New(readable),
+    Boolean::New(writable)
   };
 
   if (oncomplete_sym.IsEmpty()) {
diff --git a/src/tcp_wrap.cc b/src/tcp_wrap.cc
@@ -326,7 +326,7 @@ void TCPWrap::OnConnection(uv_stream_t* handle, int status) {
     argv[0] = client_obj;
   } else {
     SetErrno(uv_last_error(uv_default_loop()));
-    argv[0] = Local<Value>::New(node_isolate, Null(node_isolate));
+    argv[0] = Null(node_isolate);
   }
 
   MakeCallback(wrap->object(), onconnection_sym, ARRAY_SIZE(argv), argv);
@@ -352,8 +352,8 @@ void TCPWrap::AfterConnect(uv_connect_t* req, int status) {
     Integer::New(status, node_isolate),
     wrap->object(),
     req_wrap_obj,
-    Local<Value>::New(node_isolate, v8::True(node_isolate)),
-    Local<Value>::New(node_isolate, v8::True(node_isolate))
+    v8::True(node_isolate),
+    v8::True(node_isolate)
   };
   MakeCallback(req_wrap_obj, oncomplete_sym, ARRAY_SIZE(argv), argv);
 

Original file line number	Diff line number	Diff line change
`@@ -3227,12 +3227,12 @@ void EIO_PBKDF2(uv_work_t* work_req) {`
`3227`	`3227`
`3228`	`3228`	`void EIO_PBKDF2After(pbkdf2_req* req, Local<Value> argv[2]) {`
`3229`	`3229`	`if (req->err) {`
`3230`		`- argv[0] = Local<Value>::New(node_isolate, Undefined(node_isolate));`
	`3230`	`+ argv[0] = Undefined(node_isolate);`
`3231`	`3231`	`argv[1] = Encode(req->key, req->keylen, BUFFER);`
`3232`	`3232`	`memset(req->key, 0, req->keylen);`
`3233`	`3233`	`} else {`
`3234`	`3234`	`argv[0] = Exception::Error(String::New("PBKDF2 error"));`
`3235`		`- argv[1] = Local<Value>::New(node_isolate, Undefined(node_isolate));`
	`3235`	`+ argv[1] = Undefined(node_isolate);`
`3236`	`3236`	`}`
`3237`	`3237`
`3238`	`3238`	`delete[] req->pass;`
`@@ -3401,10 +3401,10 @@ void RandomBytesCheck(RandomBytesRequest* req, Local<Value> argv[2]) {`
`3401`	`3401`	`ERR_error_string_n(req->error_, errmsg, sizeof errmsg);`
`3402`	`3402`
`3403`	`3403`	`argv[0] = Exception::Error(String::New(errmsg));`
`3404`		`- argv[1] = Local<Value>::New(node_isolate, Null(node_isolate));`
	`3404`	`+ argv[1] = Null(node_isolate);`
`3405`	`3405`	`}`
`3406`	`3406`	`else {`
`3407`		`- argv[0] = Local<Value>::New(node_isolate, Null(node_isolate));`
	`3407`	`+ argv[0] = Null(node_isolate);`
`3408`	`3408`	`argv[1] = Buffer::Use(req->data_, req->size_);`
`3409`	`3409`	`}`
`3410`	`3410`	`}`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ static void After(uv_fs_t *req) {`
`121`	`121`	`}`
`122`	`122`	`} else {`
`123`	`123`	`// error value is empty or null for non-error.`
`124`		`- argv[0] = Local<Value>::New(node_isolate, Null(node_isolate));`
	`124`	`+ argv[0] = Null(node_isolate);`
`125`	`125`
`126`	`126`	`// All have at least two args now.`
`127`	`127`	`argc = 2;`